Skip to content

fix(e2e): the keyboard-scroll test notes the row in view after the end row moves it #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
V3RON merged 2 commits into from
Oct 25, 2026
Merged

fix(e2e): the keyboard-scroll test notes the row in view after the end row moves it #1007

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0a2c06
test: reproduce #1006 — the keyboard-scroll test notes the row in vie…
V3RON Oct 25, 2026
584719d
fix(e2e): the keyboard-scroll test notes the row in view after the hi…
V3RON Oct 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions e2e/console/activity.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,19 @@ test.describe("the Activity page", () => {
}) => {
const host = await startDaemon("worker", { driverScript: { ios: IOS } });
try {
let release = () => {};
const gate = new Promise<void>((resolve) => {
release = resolve;
});
// why: the real daemon answers the page before the oldest late, as on a loaded runner (#1006); the
// test notes the row in view only after the end row has moved it.
await page.route(
(url) => url.pathname === "/v1/events" && url.searchParams.has("before"),
async (route: Route) => {
await gate;
await route.continue();
},
);
for (let index = 0; index < 6; index += 1) await lease(host, `console-e2e-scroll-${index}`);
await openEvents(page, host);
await expect.poll(() => rows(page).count()).toBeGreaterThan(5);
Expand All @@ -383,11 +396,12 @@ test.describe("the Activity page", () => {
await page.keyboard.press("End");
await expect.poll(() => feed(page).evaluate((box) => box.scrollTop)).toBeGreaterThan(0);

await expect
.poll(() =>
feed(page).evaluate((box) => box.scrollHeight - box.scrollTop - box.clientHeight),
)
.toBeLessThan(2);
const atEnd = () =>
feed(page).evaluate((box) => box.scrollHeight - box.scrollTop - box.clientHeight);
await expect.poll(atEnd).toBeLessThan(2);
release();
await expect(page.getByText("Start of the history (", { exact: false })).toBeVisible();
await expect.poll(atEnd).toBeLessThan(2);
const inView = await firstRowInView(page);
await lease(host, "console-e2e-scroll-new");
const more = page.getByRole("button", { name: /^\d+ new events?$/ });
Expand Down
Loading