Repository navigation
Conversation
ws 8.18.3 -> 8.22.0, hono ^4.13.5 -> ^4.13.13, @modelcontextprotocol/sdk 1.29.0 -> 1.32.1. The lockfile also moves the SDK's vulnerable transitive deps within their ranges: proxy-addr 2.0.8, qs 6.16.1, fast-uri 3.1.9, ip-address 10.7.4. pnpm audit --prod now reports no advisories.
Contributor
Author
Review (maintainer's agent, round 1)No blocking findings.
Note, no change needed: the remaining dev-only advisories (tinypool via oxfmt, old vite/vitest via stryker) are tooling, not shipped code; they belong to a toolchain bump, not this PR. |
V3RON
added this pull request to stack #897
October 23, 2026 06:19
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pnpm audit --prodonmainreported 22 advisories (1 critical, 9 high). This PR updatesws,honoand@modelcontextprotocol/sdk, and moves the SDK's vulnerable transitive dependencies to fixed versions inside their existing ranges.pnpm audit --prodnow reports no advisories. It also adds annpmentry to Dependabot so dependencies stop drifting past advisories.Changes
ws(direct, exact pin)src/ports/uplink-websocket.ts).hono(direct)serveStaticdecodes the request path twice (GHSA-5r4p-p66f-jhc7, fixed 4.13.11);hono/jsxunescaped strings in boundaries (GHSA-hxh3-vqpv-xpqv, fixed 4.13.7).src/http/server.tsusesserveStaticfor the console.@modelcontextprotocol/sdk(direct, exact pin)proxy-addr(via SDK → express)fast-uri(via SDK → ajv)qs(via SDK → express → body-parser)ip-address(via SDK → express-rate-limit).github/dependabot.ymlnpmentry: weekly,directory: /, prefixchore(deps), one group for minor and patch@hono/node-server(2.0.10, also pinned by the workspace override) and@hono/zod-openapi(1.6.3) did not need to move: both accept hono 4.13.13. The transitive bumps came frompnpm update proxy-addr qs fast-uri ip-address hono, which only changes the lockfile.MCP SDK 1.29 → 1.32.1 release notes, the parts that touch simlock:
src/mcptests pass unchanged.tools/callwithoutargumentsand adds opt-inmaxToolInputElements. The other changes (OAuth issuer binding, HTTP redirect policy, task isolation, bearer audience) touch HTTP transports and auth, which simlock does not use.Remaining advisories
pnpm audit --prod: none.pnpm auditincluding dev dependencies still lists 15. They are out of scope here and never ship in the package:tinypoolviaoxfmt(2 critical);vite,vitest,@vitest/mockerandsource-map-jsvia@stryker-mutator/vitest-runner, which pins its own older vitest (2 high, 7 moderate, 1 low);qsvia@stryker-mutator/core→typed-rest-client(3 moderate). The new Dependabot entry will propose updates for these.Tests
pnpm exec vitest run --project unit src/mcp src/ports/uplink-websocket.test.ts src/http: 15 files, 352 tests passed.pnpm test:changed: 1 file, 6 tests passed.pnpm test:e2e e2e/gateway-smoke.test.ts e2e/mcp-session.test.ts e2e/console-serving.test.ts: 3 files, 14 tests passed. These cover a real gateway with worker uplinks overws, the HTTP app, the MCP stdio server, and console files served throughserveStatic.tsc -p tsconfig.build.jsonand the e2e typecheck passed.Assumptions
ws8.22.0,hono4.13.13, MCP SDK 1.32.1). Each is at or above its fix version and passed pnpm's supply-chain (minimum release age) check.pnpm-workspace.yamloverrides. The existingip-address: ">=10.3.1"override is unchanged.patterns: ["*"]besideupdate-types, so every package joins the minor+patch group. Majors stay one PR per package. I did not add acooldown. Dependabot's pnpm 11 lockfile support has not been checked in CI yet.Written by an agent.