Skip to content

docs(adr): 0044 the console reads what its page shows, and events mark it stale (#905) - #907

Merged
V3RON merged 11 commits into
mainfrom
feature/905-adr
Oct 23, 2026
Merged

V3RON merged 11 commits into
mainfrom
feature/905-adr

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

ADR 0044 for #905, accepted in its spec session: per-page reads through a query cache, events mark data stale in bursts, ETag/304 on JSON reads, lease.get, workerLeaseId, and GET /v1/inbox. Supersedes ADR 0013 §3.

Stays open at the bottom of #905's stack and merges with its last task.

Status

Review: passed round 2 Gate: waiting for the stack

Assumptions

none

Review

Spec review: 1 blocking, 1 fixed, 1 notes. Code review: skipped. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 2. Tokens: 2.2M.
Runs: 6. Cost USD: 1.9738. Agent seconds: 692.
Assessment: complete

Rejected:

Written by an agent.

V3RON and others added 2 commits October 23, 2026 10:59
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
V3RON and others added 2 commits October 23, 2026 11:39
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@V3RON
V3RON marked this pull request as ready for review October 23, 2026 10:14
@V3RON
V3RON added this pull request to stack #921 October 23, 2026 10:20
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review findings, round 1 (commit 30069c3)

Spec lens only (ADR-only diff). Assessment: complete.

  • R1 BLOCKING, ADR 0044 lines 97-99 and 127: says host load (a change with no event) shows within 15 s. On a gateway, a worker's host load reaches the gateway view only on its 30 s tick (ADR 0044 line 23, ADR 0029 Consequences, src/gateway/service.ts:277), so with the 15 s poll it shows within about 45-60 s. State the real bound for the gateway, or drop host load from the 15 s claim.
  • R2 rejected, incorrect: "40 requests a minute" is for an idle tab, which has no events; the busiest page's polls total under 40.
  • R3 nonblocking: 0044 supersedes only the refetch parts of 0013 section 3 (the parenthetical), so its hidden-tab paragraph (close the stream, reread on show) still stands. Could say so in one line.
  • R4 rejected, incorrect: ADR 0037's action events (lease.released, lease.rejected, worker.drain-, worker.removed) are covered by the event map in The console stays smooth and light on a big fleet #905 (lease., request/queue, worker.*).

Rerun: round 2 (R1 fix check)

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Decision taken

Question. ADR 0044 says host load shows within 15 s. On a gateway the gateway itself refreshes a worker's host load every 30 s (ADR 0029, src/gateway/service.ts:277), so with the 15 s workers poll it can take about 45 s. Which bound holds?

Options.

  • A: keep the poll intervals and correct the claim: host load shows within 15 s of the daemon serving it, about 45 s on a gateway. The operator sees nothing new; only the docs change.
  • B: shorten the gateway's 30 s host-load refresh so 15 s holds. More gateway-to-worker traffic; a code change outside this feature.
  • C: drop host load from the timing claim altogether.

Taken: A. It matches what the code does today and is a text change, easy to reverse. Folded into #905's Outcome and What could go wrong, marked pending the maintainer.

To revert: pick B and it becomes a new task under #905 (or a fix run while this PR is open).

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 30069c3
Round 2: e13cdd9

Runs: 6. Cost USD: 1.9738. Agent seconds: 692.
Tokens input 126, output 34535, cache read 2838295, cache write 234115.
- review 1 reviewer: claude-sonnet-5-5 303 s $0.1786
- review 1 reviewer spec: claude-opus-5-5 234 s $1.3338
- fix 1 implementer: claude-sonnet-5-5 33 s $0.0692
- review 2 reviewer: claude-sonnet-5-5 84 s $0.1375
- review 2 reviewer spec: claude-opus-5-5 23 s $0.1843
- review 2 reviewer claims: claude-sonnet-5-5 15 s $0.0704
Finding outcomes: {"fixed":1,"incorrect":2,"nonblocking":1}. Classes: {"ADR leaves a decision open":1,"consequence states a false bound":2,"contradicts accepted ADR":1}.
{
 "findings": [
  {
   "id": "R1",
   "role": "spec",
   "class": "consequence states a false bound",
   "outcome": "fixed",
   "path": "docs/internal/adr/0044-the-console-reads-what-its-page-shows-and-events-mark-it-stale.md",
   "round": "1",
   "fix": "e13cdd97ee757431310498d03e8ff77e21159443"
  },
  {
   "id": "R2",
   "role": "spec",
   "class": "consequence states a false bound",
   "outcome": "incorrect",
   "path": "docs/internal/adr/0044-the-console-reads-what-its-page-shows-and-events-mark-it-stale.md",
   "round": "1"
  },
  {
   "id": "R3",
   "role": "spec",
   "class": "ADR leaves a decision open",
   "outcome": "nonblocking",
   "path": "docs/internal/adr/0044-the-console-reads-what-its-page-shows-and-events-mark-it-stale.md",
   "round": "1"
  },
  {
   "id": "R4",
   "role": "spec",
   "class": "contradicts accepted ADR",
   "outcome": "incorrect",
   "path": "docs/internal/adr/0044-the-console-reads-what-its-page-shows-and-events-mark-it-stale.md",
   "round": "1"
  }
 ]
}```

_Written by an agent._

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • spec: docs/internal/adr/0044-the-console-reads-what-its-page-shows-and-events-mark-it-stale.md header supersedes only the refetch parts of ADR 0013 §3; one line saying 0013's hidden-tab paragraph still stands would remove the ambiguity.

Written by an agent.

@V3RON
V3RON merged commit bcb8d15 into main Oct 23, 2026
27 checks passed
@V3RON
V3RON deleted the feature/905-adr branch October 23, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant