Repository navigation
feat(http): unchanged JSON answers under /v1 are 304 with an ETag - #920
Merged
Merged
Conversation
V3RON
added this pull request to stack #921
October 23, 2026 10:20
Contributor
Author
Review ledgerRound 1: d9aabc0 {"findings": []}Written by an agent. |
V3RON
marked this pull request as ready for review
October 23, 2026 10:29
Contributor
Author
Review ledgerRound 1: d9aabc0 Fix-check: the CI fix (ETag step registered as {"findings": []}Written by an agent. |
Merged
7 tasks done
V3RON
added a commit
that referenced
this pull request
Oct 23, 2026
…quests a minute (#918) (#940) Closes #918 ### Status Implement: done (1/1 green) Review: round 1 passed, no blocking findings Hardware: n/a Gate: waiting for the stack - [x] The console browser lane passes with `big-fleet.spec.ts`: audit ran it with `long-lists.spec.ts` on Chromium, 24 green; CI console lane. - [x] Setting the intervals in `ui/src/state/queries.ts` back to 1 s makes it fail: audit set all six to 1 s, every page failed the ceiling (Overview 295, Queue 237, Activity 239, Leases 182, Inbox 120, Fleet 118, Usage 120 in 60 s). #905 Completion conditions: - [x] Idle tab ≤ 40 `/v1` requests in 60 s on each of the seven pages, 50 workers / 500 devices: `big-fleet.spec.ts` (this PR). - [x] A lease granted through the gateway shows on Leases within about a second: event map and burst window, #926 (#914) `ui/src/state/queries.test.ts`. - [x] Leaving a page stops its reads; coming back within a minute shows kept data: #926 (#914) polling and drop tests. - [x] A second read of an unchanged list answers 304: #920 (#919) `src/http/app.test.ts`; the console sends the tag, #927 (#916). - [x] Sidebar count reads only `GET /v1/inbox`; Inbox and Needs you read it plus `/v1/workers`: #937 (#915) `e2e/console/shell.spec.ts` and `ui/src/model/overview.test.ts`. ## Assumptions - Assumption: the stub builder is typed by `WorkerView`, derived in `big-fleet.spec.ts` as `z.infer<typeof workerViewSchema>` from the contract's exported schema; `src/contract/` is unchanged. - Assumption: `leases` and `pad` builders moved to `stub-answers.ts` with `answer`, so both specs share them. ## Review Spec review: 0 blocking, 0 fixed, 1 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes. Rounds: 1. Tokens: 23.5M. Runs: 7. Cost USD: 1.8082. Agent seconds: 2527. Assessment: complete *Written by an agent.*
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #919
Status
Implement: done (1/1 green) Review: round 1 + fix-check (CI fix) passed, no findings Hardware: n/a Gate: waiting for the stack
pnpm vitest run src/http/app.test.tspasses with the new test (ETag on a JSON read under /v1): audit ran the file, 174/174.GET /v1/tokenswithIf-None-Match: <first tag>answers 304: asserted in that test; the audit's probes (drop the mount skip, the content-type check, the tag step) each turned it red./v1/workers304s only on a gateway (no code needed).Assumptions
Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 2.5M.
Runs: 6. Cost USD: 1.4683. Agent seconds: 1107.
Assessment: complete
Written by an agent.