Skip to content

feat(gateway): read one lease directly, name the worker's lease id (#913) - #922

Merged
V3RON merged 21 commits into
task/919from
task/913
Oct 23, 2026
Merged

V3RON merged 21 commits into
task/919from
task/913

Conversation

@V3RON

@V3RON V3RON commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Closes #913

Status

Implement: done (5/5 green) Review: round 1 + 2 fix-checks passed (2 claims, 2 CI tests fixed) Hardware: n/a Gate: waiting for the stack

  • pnpm vitest run src/http/app.test.ts src/gateway/dispatcher.test.ts src/daemon/dispatcher.test.ts src/gateway/aggregate.test.ts passes: the audit ran these files plus operations.test.ts and server.test.ts, all green; 12 probes each turned a named assertion red.
  • The protocol bump check passes (protocol 57 to 58): the push hook's protocol-bump check passed.

Assumptions

  • Assumption: the existing http tests that stubbed lease.list to serve GET /v1/leases/{id} now stub lease.get — same assertions, the stub follows the operation the route now dispatches.

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 1 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 1. Tokens: 4.9M.
Runs: 9. Cost USD: 3.5044. Agent seconds: 1934.
Assessment: complete

Written by an agent.

@V3RON
V3RON changed the base branch from feature/905-adr to task/919 October 23, 2026 10:31
@V3RON
V3RON added this pull request to stack #921 October 23, 2026 10:31
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Decision taken

Question. #913's failure-modes table says a gateway lease.get for an index entry whose worker view is missing, or no longer lists the lease, answers 404 UNKNOWN_LEASE. No Tests line covered it. Test it, or leave it untested?

Options.

  • A: add it as a case of the existing "A client reads one lease" test. A user sees nothing new; the 404 is pinned.
  • B: leave it untested, as the Tests section had it.

Taken: A. The code already behaves this way; the test only pins it. Folded into #913's Tests line, marked pending the maintainer.

To revert: drop the case from the test and the Tests line.

Written by an agent.

@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 694a4e8
Round fix-check: 1eab24b

Runs: 9. Cost USD: 3.5044. Agent seconds: 1934.
Tokens input 336, output 78651, cache read 9183014, cache write 446954.
- build implementer: claude-sonnet-5-5 757 s $1.0159
- audit implementer: claude-sonnet-5-5 273 s $0.284
- fix implementer: claude-sonnet-5-5 109 s $0.1209
- review 1 reviewer: claude-sonnet-5-5 376 s $0.2498
- review 1 spec: claude-sonnet-5-5 18 s $0.1521
- review 1 code both: claude-opus-5-5 278 s $1.3631
- review 1 claims: claude-sonnet-5-5 30 s $0.1492
- fix 1 implementer: claude-sonnet-5-5 63 s $0.0869
- review fix-check reviewer: claude-sonnet-5-5 30 s $0.0825
Finding outcomes: {"fixed":2}. Classes: {"comment names removed behaviour":1,"manual false after protocol bump":1}.
{"findings":[
{"id":"R1","role":"code","class":"manual false after protocol bump","outcome":"fixed","path":"src/contract/AGENTS.md:59","round":"1","fix":"1eab24bb2"},
{"id":"R2","role":"claims","class":"comment names removed behaviour","outcome":"fixed","path":"src/http/app.ts:603","round":"1","fix":"1eab24bb2"}]}

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 23, 2026 10:48
@V3RON

V3RON commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: 694a4e8
Round fix-check: 1eab24b
Round fix-check: cd30362

Second fix-check: CI fixes (protocol test constant 57→58, gateway manual rewrapped to 150 lines), verified by coordinator.

Runs: 11. Cost USD: 3.7224. Agent seconds: 2069.
Tokens input 374, output 83291, cache read 9681512, cache write 495627.
- build implementer: claude-sonnet-5-5 757 s $1.0159
- audit implementer: claude-sonnet-5-5 273 s $0.284
- fix implementer: claude-sonnet-5-5 109 s $0.1209
- review 1 reviewer: claude-sonnet-5-5 376 s $0.2498
- review 1 spec: claude-sonnet-5-5 18 s $0.1521
- review 1 code both: claude-opus-5-5 278 s $1.3631
- review 1 claims: claude-sonnet-5-5 30 s $0.1492
- fix 1 implementer: claude-sonnet-5-5 63 s $0.0869
- review fix-check reviewer: claude-sonnet-5-5 30 s $0.0825
- fix implementer: claude-sonnet-5-5 67 s $0.0874
- review fix-check reviewer: claude-sonnet-5-5 68 s $0.1306
Finding outcomes: {"fixed":2}. Classes: {"comment names removed behaviour":1,"manual false after protocol bump":1}.
{"findings":[
{"id":"R1","role":"code","class":"manual false after protocol bump","outcome":"fixed","path":"src/contract/AGENTS.md:59","round":"1","fix":"1eab24bb2"},
{"id":"R2","role":"claims","class":"comment names removed behaviour","outcome":"fixed","path":"src/http/app.ts:603","round":"1","fix":"1eab24bb2"}]}

Written by an agent.

@V3RON
V3RON merged commit 7c55b09 into main Oct 23, 2026
32 checks passed
@V3RON
V3RON deleted the task/913 branch October 23, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

One lease is read directly, and gateway leases name the worker's lease id

1 participant