Skip to content

feat(mcp): run_on_device runs a command on the session's lease - #974

Merged
V3RON merged 14 commits into
task/958from
task/959
Oct 24, 2026
Merged

V3RON merged 14 commits into
task/958from
task/959

Conversation

@V3RON

@V3RON V3RON commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Closes #959

Status

Implement: done (7/7 green) Review: passed (round 1) Hardware: n/a Gate: waiting for the stack
Next: stack gate

  • pnpm check is green. Checked by CI on the stack's head before the gate.
  • The seven Tests lines pass in pnpm test, in src/mcp/server.test.ts and src/instructions/index.test.ts. Probed by the audit, 7/7.
  • connect-your-agent.mdx lists five tools, describes run_on_device's result and NO_LEASE, and no longer says the MCP tools do not run commands; reference/cli.mdx and introduction/index.mdx name five tools; src/mcp/AGENTS.md describes the tool and that it does not queue; the instructions text's MCP section names run_on_device. Checked by the audit and the claims review.

Feature #951 Completion conditions:

Assumptions

none

Review

Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 1 blocking, 0 fixed, 1 notes. Claims review: 0 blocking, 0 fixed, 0 notes.
Rounds: 1. Tokens: 11.3M.
Runs: 6. Cost USD: 3.2105. Agent seconds: 1543.
Assessment: complete

Rejected:

  • code: the lease_status test fails by timeout, not on an assertion, when run_on_device goes back on the queue (src/mcp/server.test.ts:881) — [incorrect] a hung lease_status is the failure its title names

Written by an agent.

@V3RON
V3RON added this pull request to stack #973 October 24, 2026 07:00
@V3RON

V3RON commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Review ledger

Round 1: ed1f736

Runs: 6. Cost USD: 3.2105. Agent seconds: 1543.
Tokens input 264, output 71011, cache read 7943116, cache write 444113.
- build implementer: claude-sonnet-5-5 584 s $0.967
- audit implementer: claude-sonnet-5-5 218 s $0.3029
- review 1 reviewer: claude-sonnet-5-5 376 s $0.3638
- review 1 reviewer spec: claude-sonnet-5-5 22 s $0.1731
- review 1 reviewer both: claude-opus-5-5 290 s $1.1906
- review 1 reviewer claims: claude-sonnet-5-5 53 s $0.2131
Finding outcomes: {"incorrect":1,"nonblocking":1}. Classes: {"progress after MCP cancel":1,"testing 2":1}.
{"findings":[
{"id":"R1","role":"code","class":"testing 2","outcome":"incorrect","path":"src/mcp/server.test.ts","round":"1"},
{"id":"R2","role":"code","class":"progress after MCP cancel","outcome":"nonblocking","path":"src/mcp/server.ts","round":"1"}
]}

Assessment: complete

Written by an agent.

@V3RON

V3RON commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

Review notes

Not blocking, not verified. Each is one reviewer's claim.

  • code: src/mcp/server.ts:300 the handler ignores extra.signal, so after an MCP cancel the client gets a progress notification for the dropped token every 10 s until the command exits

Written by an agent.

@V3RON
V3RON marked this pull request as ready for review October 24, 2026 07:11
@V3RON
V3RON merged commit a3f6d8f into main Oct 24, 2026
32 checks passed
@V3RON
V3RON deleted the task/959 branch October 24, 2026 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MCP: run_on_device runs a command on the session's lease

1 participant