Repository navigation
Conversation
…r a per-platform lease.maxPerRequester (#966)
…er-platform limit (#966)
…under a per-platform limit (#966)
…nts against the limit, not as a duplicate (#966)
…m, and refuses a duplicate on one (#966)
…cel (#966) Protocol-bump: none (the bump is already in this PR)
…ated and warned about (#966)
…ough its output schema (#966)
…roid one and refused a second iOS one (#966)
…rm through requesterLimitDecision (#966)
…cancel names one, and a numeric limit still counts all platforms (#966)
…able and the website (#966)
…nd a stale Fallow entry (#966)
Contributor
Author
Decision takenQuestion. The audit found that Options.
Why A. It changes no behaviour, only adds tests, and it guards the feature's named risk. Reverting. Delete the added dispatcher tests and the Tests line marked Written by an agent. |
Contributor
Author
Review ledgerRound 1: 7e68426 {"findings":[{"id":"R1","role":"claims","class":"comment points to a deleted comment","outcome":"fixed","path":"src/gateway/fleet-coordinator.ts","round":"1","fix":"b98a3ded3"}]}Written by an agent. |
V3RON
marked this pull request as ready for review
October 24, 2026 17:46
This was referenced Oct 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #966
Status
Implement: done Review: round 1 + fix-check passed at b98a3de Hardware: n/a Gate: running
Next: merge
Done when
pnpm test:changedpasses with the Tests lines of the issue (config:src/core/config.test.ts; worker:src/leasing/create-leasing.test.ts,physical-leasing.test.ts; gateway:src/gateway/fleet-coordinator.test.ts; client:src/simlock-client/client.test.ts; HTTP:src/http/tracker.test.ts;config.getschema:src/contract/operations.test.ts)pnpm checkis green; the gateway importsrequesterLimitDecision,HeldLeaseandMaxPerRequesterthrough the allow-list in.oxlintrc.jsonremote-agents.mdx,gateway/access-control.mdxandgateway/setup.mdxsay the limit is per requester and per platform when the operator sets the object form;agent-device.mdxsays each agent-device session is its own requester holding one devicegrepoverwebsite/src/content/docslists only lines true under both formsCompletion conditions of #961
src/leasing/create-leasing.test.ts)create-leasing.test.ts,src/daemon/dispatcher.test.ts,src/simlock-client/client.test.ts,src/http/tracker.test.ts)create-leasing.test.ts,src/core/config.test.ts)src/gateway/fleet-coordinator.test.ts,src/gateway/dispatcher.test.ts)Assumptions
{"ios":2}stays that way); a platform left out counts as 1 where the limit is read, not at load.FleetLease).waiting && !atLimitin the object-form refusal picks the held text when both hold, as the issue says; that state is not reachable through a request, so no test reaches it.Review
Spec review: 0 blocking, 0 fixed, 0 notes. Code review: 0 blocking, 0 fixed, 0 notes. Claims review: 1 blocking, 1 fixed, 0 notes.
Rounds: 1. Tokens: 5.1M.
Runs: 9. Cost USD: 7.7673. Agent seconds: 3498.
Assessment: complete
Written by an agent.