Audit/git drs#236
Conversation
…an one bucket is supported
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: eb5dfd531a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| return fmt.Errorf("failed to resolve pushed paths: %w", err) | ||
| } | ||
| if _, err := drsdelete.ReconcileCommittedDeletes(ctx, drsClient, deleteRefs, myLogger); err != nil { | ||
| lfsFiles, err := lfs.GetLfsFilesForRefPaths("HEAD", pushedPaths, myLogger) |
There was a problem hiding this comment.
When the branch has an upstream, listRefUpdatePaths returns only paths changed between the upstream and HEAD, so this call scans only those changed paths for LFS pointers. If a user pushes the branch to a fresh DRS remote (or retries after metadata/payload upload was missed) while HEAD contains unchanged LFS pointer files, those objects are skipped entirely before git push, leaving the pushed commit referencing DRS payloads that were never registered/uploaded to that remote; the previous GetAllLfsFiles(..., []string{"HEAD"}, ...) path covered all LFS pointers in HEAD.
Useful? React with 👍 / 👎.
1 participant
No description provided.