Repository navigation
Conversation
Add settings_overrides table and SETTINGS_BACKEND=db opt-in so operator overrides live in the database instead of editable YAML files. Existing file overrides are imported on first bootstrap when the table is empty. Admin PATCH and restore save through a single async restore path.
🦋 Changeset detectedLatest commit: a351a51 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Coverage Report for CI Build 40061005497Warning No base build found for commit Coverage: 75.154%Details
Uncovered Changes
Coverage RegressionsRequires a base build to compare against. How to fix this → Coverage Stats💛 - Coveralls |
[Medium impact] The changes reach settings storage and runtime configuration within a relay deployment. This PR needs fixes before merging because notification overrides still fail to load, workers keep old settings, and config commands can stay open. Findings
|
JSON-encode jsonb values, preserve dotted map keys and empty arrays, reload overrides across workers, route CLI and notifications through the db store, and backup before database replaces.
| } | ||
|
|
||
| export const runConfigList = async (options: { json?: boolean } = {}): Promise<number> => { | ||
| await bootstrapSettingsStore() |
There was a problem hiding this comment.
With SETTINGS_BACKEND=db, the config commands now open the shared database pool but never close it. Returning from the command does not exit the CLI because the database connections remain open. With the default settings, commands wait for the 60-second idle timeout after printing their result. If DB_MIN_POOL_SIZE is above zero, they can remain open indefinitely.
Close the database client after each one-shot command, including error paths.
Description
This PR adds settings_overrides table and SETTINGS_BACKEND=db opt-in so operator overrides live in the database instead of editable YAML files. Existing file overrides are imported on first bootstrap when the table is empty. Admin PATCH and restore save through a single async restore path.
Related Issue
Fixes :- #757
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: