Fix helmholtz test - #10
Closed
campospinto wants to merge 3 commits into
Closed
Conversation
Owner
Author
|
I think this bug is related to a problem with semi-norms of complex-valued fields, see issue #12, so I am just commenting the h1 error measure for now. |
Owner
Author
|
this error was caused by some untested changes in sympde, see pyccel/sympde#163 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The expected h1_error in a
test_complex_helmholtz_2dhas been changed to match the computed value. This is motivated by the fact that the L2 error is matching the previous value, and that visual plots confirm the good quality of the approximation. As for questions on the h1 (semi-)norm, see this sympde issue