Update go module to use canonical name#45
Merged
Merged
Conversation
swetha1654
commented
Jun 23, 2026
swetha1654
commented
Contributor
- Address the issue raised by sd-tools.
- Update the release.yaml for user input on tag since it currently updates patch version but this change requires a major version bump.
swetha1654
requested review from
Thanhphan1147 and
yhaliaw
and removed request for
a team
swetha1654
changed the title
swetha1654
changed the title
javierdelapuente
approved these changes
Jun 23, 2026
Collaborator
|
Hey @swetha1654, sorry I didn't see this pull request, but the aproxy version is defined in the snap files. Could you maybe to help to add a check to ensure the git version and snap version are synchronized? Lines 2 to 3 in 675180f |
Contributor
Author
|
@weiiwang01 , sure let me update it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.