feat: abstract interactions with archive/store#311
Open
upils wants to merge 5 commits into
Open
Conversation
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
upils
changed the title
upils
commented
Jul 15, 2026
| // fetch function returning the package reader and metadata. The fetch | ||
| // function is bound at resolution time, so callers are agnostic to whether | ||
| // the package comes from an archive or a store. | ||
| type pkgSource struct { |
Collaborator
Author
There was a problem hiding this comment.
[Note to reviewer]: This struct could be extracted to a dedicated package and exported since in the future this abstraction might be useful in other packages, such as cmd_debug_check_release_archives.go.
upils
commented
Jul 15, 2026
| // the package comes from an archive or a store. | ||
| type pkgSource struct { | ||
| arch string | ||
| fetch func() (io.ReadSeekCloser, *archive.PackageInfo, error) |
Collaborator
Author
There was a problem hiding this comment.
[Note to reviewer]: If we adopt this approach, PackageInfo should likely be extracted to its own package as it will not be specific to the archive anymore and should also be usable by the future store package. This is slightly tangential to changes of this PR so I differed this change for now.
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch introduces a
pkgSourcestruct in the slicer that abstracts package fetching via a closure, replacing the previous directmap[string]archive.Archivelookup. This is needed because packages can now come from either archives or stores, and the slicer'sRunfunction must handle both in a generic way. The closure captures the resolved archive or a store error (until the store is implemented) at resolution time, keepingRunsource-agnostic. Store packages are not yet fetchable and return a clear "not implemented" error, with a test covering this path.This lays the groundwork for implementing store fetching without further changes to the slicer's core logic.
upils#21 implements another approach to solve this, relying on a
Sourceinterface and aFetchOptionmarker interface. This approach seems more convoluted without obvious major advantages.