Cluster manager reverse tunnel#801
Open
edlerd wants to merge 1 commit into
Open
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
edlerd
force-pushed
the
websocket
branch
7 times, most recently
from
1d36035 to
e4741bd
Compare
Contributor
|
@edlerd can this PR be closed? |
Contributor
Author
We might want to use this approach at a later time, so I'd keep it open in draft state. |
edlerd
force-pushed
the
websocket
branch
3 times, most recently
from
99939f7 to
0f73e50
Compare
edlerd
force-pushed
the
websocket
branch
6 times, most recently
from
03a8fa9 to
99d12b3
Compare
| }, | ||
| } | ||
|
|
||
| lxdResponse, err := lxdHttpClient.Do(newReq) |
Contributor
Author
There was a problem hiding this comment.
This is by design, not sure if there is a solution for this.
Contributor
Author
There was a problem hiding this comment.
Added an allowlist of methods and a prefix check for the path.
edlerd
force-pushed
the
websocket
branch
3 times, most recently
from
8988de9 to
f1f9f2f
Compare
edlerd
changed the title
edlerd
force-pushed
the
websocket
branch
3 times, most recently
from
851f04d to
1f74f54
Compare
Signed-off-by: David Edler <david.edler@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
Ready for review.