[MISC] Add ty typechecking#1744
Draft
dragomirp wants to merge 4 commits into
Draft
Conversation
Fix all 194 type errors reported by ty across 11 source files. Main patterns fixed: annotate self.charm as PostgresqlOperatorCharm via TYPE_CHECKING guards, add str | None narrowing for optional secrets and endpoints, fix implicit None returns, convert dict_keys to list before subscripting, and suppress dynamic Literal constructs with ty: ignore. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
dragomirp
added
the
not bug or enhancement
github-actions
Bot
added
the
Libraries: Out of sync
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
|
|
||
| @property | ||
| def _relation(self) -> Relation: | ||
| def _relation(self) -> Relation | None: |
| raise Exception("Cannot get version found.") | ||
|
|
||
| def get_member_ip(self, member_name: str) -> str: | ||
| def get_member_ip(self, member_name: str) -> str | None: |
dragomirp
force-pushed
the
ty-typechecking
branch
from
4e35b03 to
e614515
Compare
| return {self.unit, *self._peers.units} | ||
|
|
||
| def scoped_peer_data(self, scope: Scopes) -> dict | None: | ||
| def scoped_peer_data(self, scope: Scopes) -> RelationDataContent | dict[str, str] | None: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Checklist