fix(backups): configure pgBackRest stderr logging#1750
Conversation
taurus-forever
left a comment
There was a problem hiding this comment.
Should this
postgresql-operator/src/constants.py
Line 34 in 82b1194
|
I don’t think a separate constant needs to be reverted in this PR. The command-level This PR applies the earlier suggestion in the config layer instead: The only remaining command-level logging flag I see on |
|
@taurus-forever perhaps we should set the default branch to |
It was pending stereo mode PRs release to perform massive default branch upgrade as discussed in Madrid. |
marceloneppel
left a comment
There was a problem hiding this comment.
LGTM!
I created #1767 to also work on 16/edge and remove the constant @taurus-forever mentioned.
Summary
Adds
log-level-stderr=warnto the rendered pgBackRest global configuration so the stderr logging level is configured once for every pgBackRest invocation that usespgbackrest.conf, as requested in #1353.The existing
--log-level-console=debugbackup argument is left unchanged because it controls console output for the backup action and is distinct from the stderr logging level being moved into the config file.Verification
python3 -m compileall -q tests/unit/test_backups.pyruff check tests/unit/test_backups.pyruff format --check tests/unit/test_backups.pygit diff --checklog-level-stderr=warnappears in the rendered configCould not run the focused pytest locally because this container lacks the project test environment: host pytest autoloads a missing
evalcraftplugin, plugin-autoload-disabled pytest then lacksbotocore, andpoetry/toxare not installed here.Closes #1353