[DPE-10062] Switch to shared cluster code#1764
Draft
dragomirp wants to merge 6 commits into
Draft
Conversation
5670496 to
283b12e
Compare
8c9d324 to
1fe33ca
Compare
marceloneppel
added a commit
that referenced
this pull request
Jun 12, 2026
Integration tests were importing constants via 'from constants import ...' (which eagerly imports single_kernel_postgresql in its module body) and directly via 'from single_kernel_postgresql... import'. The integration CI env runs 'poetry install --only integration --no-root' which does not install the lib, causing ModuleNotFoundError at pytest collection time for every spread job. Hardcode the needed constant values locally in each file, matching PR #1764's style, so no integration file transitively imports the lib. One documented exception remains: test_charm.py retains 'from single_kernel_postgresql.config.locales import LOCALES as SNAP_LOCALES' because it asserts against a 510-entry locale list that cannot be practically hardcoded. Signed-off-by: Marcelo Henrique Neppel <neppel2026@proton.me> Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Checklist