[DPE-10235] fix: bypass HTTP proxy for intra-cluster Patroni API calls#132
Draft
marceloneppel wants to merge 3 commits into
Draft
[DPE-10235] fix: bypass HTTP proxy for intra-cluster Patroni API calls#132marceloneppel wants to merge 3 commits into
marceloneppel wants to merge 3 commits into
Conversation
Set trust_env=False on httpx.AsyncClient in parallel_patroni_get_request so proxy environment variables are ignored for intra-cluster Patroni communication. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Verify that AsyncClient is created with trust_env=False to prevent proxy environment variables from intercepting intra-cluster Patroni API calls. Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
Signed-off-by: Marcelo Henrique Neppel <marcelo.neppel@canonical.com>
2 tasks
marceloneppel
changed the title
marceloneppel
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
When deployed behind an HTTP proxy (configured via
cloudinit-userdatawriting to/etc/environment),parallel_patroni_get_requestpicks upHTTPS_PROXYand routes intra-cluster Patroni API calls through the proxy. Unlikerequests/urllib3, httpx does not honor CIDR ranges inno_proxy(e.g.10.0.0.0/8), so Squid receives the CONNECT request and returnshttpx.ProxyError: 403 Forbidden. This causescluster_status()andget_primary()to fail, leaving the charm stuck in "awaiting start of the primary".Solution
Set
trust_env=Falseonhttpx.AsyncClientinparallel_patroni_get_requestso proxy environment variables are ignored for intra-cluster Patroni communication.Checklist