Skip to content

OneClickAppDefinitionResponse types appTemplate as string, but backend returns an object #11

Description

@githubsaturn

The getOneClickAppByName SDK response model currently declares appTemplate: string, while the CapRover backend returns the parsed template object from /user/oneclick/template.

This forces consumers to cast through unknown before using the fetched template with startOneClickAppDeploy.

Observed while adding repository-backed one-click deployment coverage in caprover/caprover-e2e#36.

Suggested fix:

  • Change OneClickAppDefinitionResponse.appTemplate to IOneClickTemplate.
  • Add a contract test covering the response from getOneClickAppByName.
  • Publish the corrected SDK type and then remove the temporary cast in the E2E test.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions