Skip to content

test: cover registries, GoAccess, and NetData - #38

Merged
githubsaturn merged 3 commits into
mainfrom
test/pr17-registries-observability
Sep 23, 2026
Merged

githubsaturn merged 3 commits into
mainfrom
test/pr17-registries-observability

Conversation

@githubsaturn

@githubsaturn githubsaturn commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Implements PR17 from E2E_TEST_PLAN.md with three destructive-tier files. Uses published caprover-api@0.0.25 after SDK PR #17 and release PR #19.

The registry test proves GHCR reachability from the CapRover host before asserting rejected credentials. GoAccess and NetData preserve and restore settings and check standalone Docker containers; NetData exercises the cookie-authenticated public proxy.

Validation: npm ci, npm run typecheck, npm run format, and npm run test:unit (76 tests) passed locally. Direct destructive invocation rejects without ephemeral mode. Fresh-server run #35820353928 passed on commit e9bf75c: 36 files, 104 tests, including all three PR17 files. Provisioning and infrastructure cleanup passed. Requested server image: caprover/caprover-edge; resolved digest: caprover/caprover-edge@sha256:d4479169128736e43ada91abb243328a3771f563a6b4d5f56942e27e319c3d6f. The subsequent commit updates only the completion checklist.

@coderabbitai

coderabbitai Bot commented Sep 23, 2026 •

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 5 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Advanced

Run ID: c2a0ce25-2663-4720-b3bf-876bb1774745

📥 Commits

Reviewing files that changed from the base of the PR and between 8fe1ad0 and ab0195e.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (8)
  • E2E_TEST_PLAN.md
  • package.json
  • src/clients/caprover.ts
  • src/inspectors/docker.ts
  • tests/goaccess.test.ts
  • tests/netdata.test.ts
  • tests/registries.test.ts
  • tests/unit/docker.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

githubsaturn commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor Author

Fixed in commit e9bf75c. DataStore.getNetDataInfo() normalizes smtp to {} when the username is empty; the E2E assertion now checks that result while continuing to verify the other notification fields. Typecheck, formatting, and 76 unit tests pass locally.

@githubsaturn
githubsaturn merged commit ba67c21 into main Sep 23, 2026
1 check passed
@githubsaturn
githubsaturn deleted the test/pr17-registries-observability branch September 24, 2026 04:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant