Reseed the guest crng on resume - #86
Merged
Merged
Conversation
…e isolation in sandboxes
…d integration tests to verify entropy uniqueness
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vpod sandboxes returned the same random bytes, same uuid4 etc.. every time.
The
crngis captured already initialized, andcredit_init_bits()returns early oncecrng_ready()is true, soRNDADDENTROPYalone is a no-op on a restore.RNDRESEEDCRNGis what re-keys it. This runs both, at resume, with fresh host bytes on the line that already syncs the clock.Seeder from #79 => This adds the second ioctl and moves it from build time to resume time.