Disposal rate method#1022
Open
henrydingliu wants to merge 25 commits into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1022 +/- ##
==========================================
- Coverage 89.38% 89.31% -0.07%
==========================================
Files 91 91
Lines 5266 5232 -34
Branches 678 666 -12
==========================================
- Hits 4707 4673 -34
Misses 391 391
Partials 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 87857fe. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary of Changes
Implement the disposal rate method
Related GitHub Issue(s)
closes #931
Additional Context for Reviewers
uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Medium Risk
New reserving logic touches IBNR allocation and LDF derivation with required ultimate alignment; scope is additive with tests but actuarial correctness is business-critical.
Overview
Adds
DisposalRate, a Friedland-style adjustment that forecasts future emergence as a share of an external ultimate passed viasample_weight(e.g. incurred ultimate to drive a paid payment pattern).fitbuilds observed disposal rates from cumulativeX/ ultimate, appliesTriangleWeightdrop rules (with documented order that differs fromDevelopmentfor rank vs range drops), and fits a cumulativedisposal_/ incrementalincr_disposal_pattern throughDevelopmentBase.transform/fit_transformreallocate IBNR using that pattern and refreshldf_/full_triangle_;sample_weightis required on fit and transform.DisposalRateis exported fromchainladder.adjustmentsand the top-level package; public API tests include it.MethodBase.validate_weightis now a@staticmethodwith type hints soDisposalRatecan validate ultimates without a full method fit.New tests cover Friedland sample fidelity, missing-weight errors, parity with volume-weighted
Chainladder, and sparse-backend output.Reviewed by Cursor Bugbot for commit 7459e8e. Bugbot is set up for automated code reviews on this repo. Configure here.