Disposal

[henrydingliu]

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

• I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

---

Note

Medium Risk
The disposal_ terminal column construction change can alter downstream disposal patterns and full_triangle_ forecasts; tests add parity checks but actuarial outputs should be spot-checked.

Overview
DisposalRate.fit appends the terminal development column to disposal_ using X.latest_diagonal*0 + 1 instead of ult/ult, so the 100% disposal slice matches the paid triangle’s shape rather than the ultimate weight triangle.

The DisposalRate docstring examples are rewritten around clrd / DisposalRate (emergence via disposal_rate_tri, pattern in disposal_, forecast in full_triangle_), replacing the previous Berquist–Sherman trend copy-paste.

Tests are reorganized and extended: Friedland fidelity is renamed, no-weight checks use the raa fixture, and new coverage asserts Chainladder parity on sparse raa and that full_triangle_ stays a sparse COO after fit_transform.

^{Reviewed by Cursor Bugbot for commit 4b8dea4. Bugbot is set up for automated code reviews on this repo. Configure here.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.22%. Comparing base (252878e) to head (4b8dea4).
⚠️ Report is 18 commits behind head on disposal_rate_method.

Additional details and impacted files

@@                  Coverage Diff                  @@
##           disposal_rate_method    #1034   +/-   ##
=====================================================
  Coverage                 89.22%   89.22%           
=====================================================
  Files                        91       91           
  Lines                      5226     5226           
  Branches                    666      666           
=====================================================
  Hits                       4663     4663           
+ Misses                      396      394    -2     
- Partials                    167      169    +2     

Flag	Coverage Δ
unittests	89.22% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.