Skip to content

more fixes #1040

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrydingliu merged 1 commit into from
Jun 21, 2026
+4 −3
Merged

more fixes #1040

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions chainladder/adjustments/disposal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,8 +211,8 @@ def fit(
ult = sample_weight.copy()
#calculate disposal rate triangle
self.xp = X.get_array_module()
self.X_ = X.sort_index()
self.disposal_rate_tri = X / ult.values
self.X_ = X.incr_to_cum().sort_index()
self.disposal_rate_tri = self.X_ / ult.values
#get weights for estimation
tw = TriangleWeight(
n_periods = self.n_periods,
Expand Down
3 changes: 2 additions & 1 deletion chainladder/adjustments/tests/test_disposal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ def test_cl_parity(raa):

def test_sparse_transform(raa):
raa_sparse = raa.set_backend('sparse')
ult = cl.Chainladder().fit(raa_sparse).ultimate_.set_backend('sparse')
dr = cl.DisposalRate().fit_transform(raa_sparse,sample_weight=ult)
from chainladder.utils.sparse import sp
dr = cl.DisposalRate().fit_transform(raa_sparse,sample_weight=cl.Chainladder().fit(raa_sparse).ultimate_)
assert isinstance(dr.full_triangle_.values,sp.COO)

Loading