Skip to content

sync#1041

Merged
henrydingliu merged 4 commits into
disposal_rate_methodfrom
main
Jun 21, 2026
Merged

sync#1041
henrydingliu merged 4 commits into
disposal_rate_methodfrom
main

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Summary of Changes

Related GitHub Issue(s)

Additional Context for Reviewers

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Small refactor plus I/O test coverage; Development keeps its own three-argument _param_property, so incremental behavior should follow the moved helper unchanged.

Overview
Triangle pickle I/O is documented at the module level in chainladder/core/io.py, with imports reordered and an unused joblib import dropped from that file (pickling still uses dill).

Development estimators: _param_property is added as a static helper on DevelopmentBase, and the duplicate implementation is removed from IncrementalAdditive, which now calls the shared helper for zeta_. Type hints in DevelopmentBase switch from TriangleLike to Triangle for _set_fit_groups.

Tests: test_triangle_to_pickle exercises Triangle.to_pickle / read_pickle round-trips for single- and multi-dimensional sample triangles (raa, clrd).

Reviewed by Cursor Bugbot for commit 468f11a. Bugbot is set up for automated code reviews on this repo. Configure here.

@henrydingliu henrydingliu marked this pull request as ready for review June 21, 2026 09:15
@henrydingliu henrydingliu merged commit 7459e8e into disposal_rate_method Jun 21, 2026
23 checks passed
@codecov

codecov Bot commented Jun 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.38%. Comparing base (b6e8349) to head (468f11a).
⚠️ Report is 29 commits behind head on disposal_rate_method.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           disposal_rate_method    #1041      +/-   ##
========================================================
+ Coverage                 89.17%   89.38%   +0.20%     
========================================================
  Files                        89       91       +2     
  Lines                      5165     5266     +101     
  Branches                    661      678      +17     
========================================================
+ Hits                       4606     4707     +101     
+ Misses                      392      391       -1     
- Partials                    167      168       +1     
Flag Coverage Δ
unittests 89.38% <100.00%> (+0.20%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants