Repository navigation
Conversation
IvasgnNode built the class-scope closure for an instance variable assigned in a module_function method without source:, so SOLARGRAPH_ASSERTS=on raised "source not provided" while mapping it. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LDU6pFM33xXZg3WEppPqP6
apiology
marked this pull request as ready for review
October 19, 2026 16:17
…vars Brings in the 10 commits on castwide/master since this branch was cut. No conflicts.
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Oct 20, 2026
…module_function methods
apiology
added a commit
to apiology/solargraph
that referenced
this pull request
Oct 21, 2026
…module_function methods
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude: This PR was written by Claude Code on behalf of @apiology.
Problem:
With
SOLARGRAPH_ASSERTS=on, an ivar assigned in amodule_functionmethod crashes mapping:This aborts strong typechecking of any project that memoizes in a
module_functionmethod, includingCacheDir.pluginsin #1407.Solution:
Give the module-scope closure pin
source: :parser, as its sibling pins inivasgn_node.rbalready have.