Fix an intermittent bootstrap failure after cache purges#78
Open
frederikmillingpytlick wants to merge 2 commits into
Open
Fix an intermittent bootstrap failure after cache purges#78frederikmillingpytlick wants to merge 2 commits into
frederikmillingpytlick wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During
tool_forcedcache_cache_factory::create_config_instance(), cache config loading can re-enter Moodle cache setup and reset the factory’s internal$configsarray. The method then attempted to return$this->configs[$class], which could emit anundefinedarray key warning and returnnull, leading to:Call to a member function get_definition_by_id() on nullThis patch keeps the newly created config instance in a local variable, loads it, then re-registers it in
$this->configsafter load completes. That makes the method robust if$this->configsis reset during config generation.Tested with:
It doesn't seem to be an issue in the
MOODLE_501_STABLEbranch