chore: adopt the shared PR review bot - #10
Closed
shlomicm wants to merge 1 commit into
Closed
Conversation
Assigns a reviewer and assignee to open PRs that have neither and DMs them on Slack, using the action published in cm-agents rather than a copy of the script. No configuration needed here: PR_REVIEWER_ROSTER and SLACK_BOT_TOKEN are organisation-level. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Author
|
Closing: cm-proxy is one of the two public repos in the org, and a public repo cannot consume a private action. The run confirms it, with all three permissions correctly present: The only ways round it are making cm-agents public, or copying the script here and accepting the drift the shared action exists to prevent. cm-proxy has no branch protection, so reviewer assignment is cosmetic here either way. Not worth either cost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopts the shared PR review bot: one workflow file, no script. The logic lives in
causematch/cm-agents/actions/pr-review-bot,so every repo runs the same code instead of a copy that drifts.
Assigns a reviewer and an assignee to open PRs that have neither, spreads load
toward a soft weekly target, and DMs the assignee on Slack.
Nothing to configure
PR_REVIEWER_ROSTERandSLACK_BOT_TOKENare organisation-level. The actioncarries its own script and never checks out this repo, so no
.nvmrcand nodevops/directory are needed.Already proven
Verified end to end in cm-payments#120, which was assigned by the very bot it was
adopting: cross-repo action resolution, org variable, org secret and all three
permission scopes.
Review the permissions block, not the workflow
An explicit
permissions:block makes every unlisted scopenone, and no testcan catch a missing one because the unit suite uses a stub client, never a real
token. A missing
contents: readshipped in cm2 behind 19 green checks and leftthe bot inert for a day.
contents: readand the action cannot be fetchedpull-requests: writeand the review request failsissues: writeand the assignee step fails🤖 Generated with Claude Code