Skip to content

Make manual review persistence durable#138

Merged
shiny-code-bot merged 1 commit into
mainfrom
manual-review-durable-lifecycle
Jun 19, 2026
Merged

Make manual review persistence durable#138
shiny-code-bot merged 1 commit into
mainfrom
manual-review-durable-lifecycle

Conversation

@shiny-code-bot

Copy link
Copy Markdown
Collaborator

Summary

  • make manual persisted reviews claim a review snapshot epoch and persist Pending before entering review mode
  • cancel/supersede existing background review state before durable manual review startup
  • drop persistence for the manual review if the durable start cannot be recorded, avoiding misleading partial run records
  • add regression coverage for completed/cancelled manual runs and background-to-manual durable handoff

Verification

  • cargo fmt --all -- --check
  • git diff --check
  • just test -p codex-core review_op_with_persistence_writes_auto_review_run review_op_with_persistence_writes_cancelled_run_when_interrupted manual_review_with_persistence_supersedes_running_background_review
  • focused read-only agent review: no blocking issues

Notes

Background auto-review for this branch did not produce semantic findings because the current diff exceeded the configured review size limit. Focused review agents and targeted tests covered the changed lifecycle path.

@shiny-code-bot shiny-code-bot merged commit 88f724c into main Jun 19, 2026
6 checks passed
@shiny-code-bot shiny-code-bot deleted the manual-review-durable-lifecycle branch June 19, 2026 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant