Move ingress canary reads to FastAPI#1396
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ingress_canary_route.readauthorization and record-store read semantics, including list filters and bounded limit parsing.Refs #1322
Validation
uv run python -m unittest tests.test_http_app.FastApiIngressCanaryRouteReadTests tests.test_service.LaunchplaneServiceTests.test_ingress_canary_route_record_apply_stores_route_authority tests.test_service.LaunchplaneServiceTests.test_ingress_canary_route_apply_resolves_profile_and_edge_endpoint tests.test_service.LaunchplaneServiceTests.test_ingress_canary_route_apply_idempotency_ignores_record_changes tests.test_service.LaunchplaneServiceTests.test_ingress_canary_route_apply_rejects_missing_profile tests.test_service.LaunchplaneServiceTests.test_ingress_canary_route_apply_rejects_disabled_profile tests.test_service.LaunchplaneServiceTests.test_ingress_canary_route_apply_authorizes_before_profile_lookup tests.test_service.LaunchplaneServiceTests.test_ingress_canary_route_read_routes_are_retired_from_legacy_wsgi_appuv run --extra dev ruff check --exit-zero control_plane/http_app.py control_plane/service.py tests/test_http_app.py tests/test_service.py docs/service-boundary.md docs/compatibility-retirement.mduv run --extra dev ruff format --check control_plane/http_app.py control_plane/service.py tests/test_http_app.py tests/test_service.pygit diff --checkuv run --extra dev ruff check control_plane/http_app.py control_plane/service.py tests/test_http_app.py tests/test_service.py docs/service-boundary.md docs/compatibility-retirement.mduv run --extra dev mypy control_plane testsuv run --extra dev ruff check .uv run python -m unittest