Repository navigation
feat(infra): add Tarmac to the mill.render audience allowlist - #59
Conversation
Adds neuralliquid-tarmac-mill-s2s to mystira_oidc_render_audiences alongside the existing nexamesh-coiltrace-web entry, so Tarmac's new OpenIddict client-credentials client (companion PR in phoenixvc/mystira-workspace) can call Mill's LaTeX-render endpoints with a mill.render-scoped token. No dedicated resource audience was minted on the Mystira side, so this client's own client id is the value to allow here, matching the existing CoilTrace precedent. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 3 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (1)
🔇 Additional comments (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughThe production Terraform configuration now accepts ChangesOIDC audience configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This adds Tarmac’s client ID to the production render-audience allowlist without changing application code; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
JustAGhosT has reached the 50-credit limit for trial accounts. To continue receiving code reviews, upgrade your plan.
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (1 file)
Reviewed by free · Input: 56.6K · Output: 5.8K · Cached: 234.8K |
Summary
neuralliquid-tarmac-mill-s2stomystira_oidc_render_audiencesininfra/env/prod/terraform.tfvars, alongside the existingnexamesh-coiltrace-webentry.neuralliquid/tarmac) new OpenIddict client-credentials S2S client for document-render calls — companion PR: phoenixvc/mystira-workspace#4063 (draft, adds theneuralliquid-tarmac-mill-s2sconfidential client).audclaim, matching the existing CoilTrace precedent (nexamesh-coiltrace-webis listed here by its own client id too).backend/auth.py'sget_render_usercomma-splits this env var, so no app-code change is needed.Test plan
terraform fmt -check -diffpasses on the editedterraform.tfvars.packages/launchpad/src/mill.ts) is deployed.🤖 Generated with Claude Code