Fixing find_first - #3
Open
olance wants to merge 2 commits into
Open
Conversation
First test highlights that `find_first` fails when it is used to find a single record with a condition on the partition key. Second test was missing: we should check that `find_first` returns `nil` when no record could be found, as documented.
Because of the way `scope` is built (using `#[]`), it could sometimes return a single `Record` instance instead of a `RecordSet`. This change accounts for this to avoid exceptions when calling `#first` blindly on the returned value from `#construct_scope`.
|
Is this issue still outstanding with the master branch of orm_adapter-cequel? Would be nice to merge this fix if the issue is still there. |
|
Any word on when this fix will be merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1 by checking whether
scopeis aRecordand whether it really exists, to return the proper value.Added two tests to support this change.