Skip to content

Add new verify and fix targets for GH actions#639

Open
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:pinact
Open

Add new verify and fix targets for GH actions#639
erikgb wants to merge 1 commit into
cert-manager:mainfrom
erikgb:pinact

Conversation

@erikgb

@erikgb erikgb commented Jun 12, 2026

Copy link
Copy Markdown
Member

Today I found https://github.com/suzuki-shunsuke/pinact, which seems like a useful tool to ensure pinned actions correspond with version comments. This is something I have been trying to manually fix in a lot of our repos, but I still think there are leftovers. Having a check that an action digest corresponds to the release in the comment behind the action declaration will also improve security, but the biggest benefit IMO is to make things more human-readable and avoid PRs from Renovate just bumping a digest for an action. These PRs always make me suspicious.

I am proposing a new module for this, which could also be used as a new home for generic reusable GH workflows. I am planning to change #651 after this is merged to source the OSSF Scorecard workflow from this new module. Also planning to source https://github.com/cert-manager/makefile-modules/blob/main/.github/workflows/validate-renovate-config.yaml from the module

@cert-manager-prow cert-manager-prow Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. labels Jun 12, 2026
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign munnerz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 12, 2026
@wallrj-cyberark wallrj-cyberark self-requested a review June 16, 2026 10:05
@cert-manager-prow cert-manager-prow Bot added dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 21, 2026
@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. and removed dco-signoff: no Indicates that at least one commit in this pull request is missing the DCO sign-off message. labels Jun 21, 2026
@erikgb erikgb changed the title WIP: Add new verify and fix targets for GH actions Add new verify and fix targets for GH actions Jun 21, 2026
@cert-manager-prow cert-manager-prow Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 21, 2026
@erikgb erikgb requested a review from Copilot June 21, 2026 19:17

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Introduces pinact into the makefile-modules toolchain and adds Make targets to verify/fix pinned GitHub Actions digests while ensuring version comments match, improving workflow readability and pinning hygiene.

Changes:

  • Add pinact as a managed tool (version + Go install source).
  • Add verify-pinact / fix-pinact targets under a new gh-actions module.
  • Include the new module from the repository Makefile so targets participate in make verify.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
modules/tools/00_mod.mk Adds pinact to the managed tool/version list and Go dependency install list.
modules/gh-actions/01_mod.mk Introduces verify-pinact and fix-pinact Make targets using pinact.
Makefile Includes the new modules/gh-actions/01_mod.mk module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread modules/gh-workflows/01_mod.mk
Signed-off-by: Erik Godding Boye <egboye@gmail.com>
@erikgb

erikgb commented Jun 21, 2026

Copy link
Copy Markdown
Member Author

/cc @inteon

@cert-manager-prow cert-manager-prow Bot requested a review from inteon June 21, 2026 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants