refactor(ui): shared presentational primitives + slot→snippet [P6.02]

docs/product/delivery/phase-06/reviews/P6.02-pr-review.triage.json

@@ -0,0 +1,10 @@
+{
+  "schemaVersion": 1,
+  "recordedAt": "2026-06-17T03:10:14.665Z",
+  "outcome": "skipped",
+  "note": "PR review disabled by policy",
+  "prBodyRefresh": {
+    "attemptedAt": "2026-06-17T03:10:17.289Z",
+    "status": "updated"
+  }
+}

docs/product/delivery/phase-06/reviews/P6.02-subagent-review.ledger.json

@@ -0,0 +1,69 @@
+{
+  "ticket": "P6.02",
+  "invocations": [
+    {
+      "runnerKind": "claude-cli",
+      "reviewedHeadSha": "ea40e08cc4782cf61740b47d492b278825035514",
+      "outcome": "clean",
+      "completedAt": "2026-06-17T03:06:21.809Z",
+      "terminatedReason": "completed",
+      "rawOutput": "docs/product/delivery/phase-06/reviews/P6.02-subagent-review.report.md",
+      "filledPrompt": "docs/product/delivery/phase-06/reviews/P6.02-subagent-review.prompt.md",
+      "fallbackLevel": "preferred",
+      "schemaVersion": 1,
+      "primaryAgent": "claude",
+      "runnerSelfReport": null,
+      "fallbackFrom": null,
+      "findings": [],
+      "probedSurfaces": [],
+      "patches": []
+    },
+    {
+      "runnerKind": "operator-recorder",
+      "reviewedHeadSha": "ea40e08cc4782cf61740b47d492b278825035514",
+      "completedAt": "2026-06-17T03:07:55.662Z",
+      "terminatedReason": "completed",
+      "findings": [],
+      "probedSurfaces": [],
+      "patches": [],
+      "schemaVersion": 1,
+      "primaryAgent": "claude",
+      "runnerSelfReport": null,
+      "fallbackFrom": null,
+      "outcome": "clean",
+      "acknowledgment": "operator-confirmed-clean",
+      "reason": "Subagent report Actionable findings section says 'None.' followed by explanatory prose; reconciler regex requires bare 'None.' — no actual findings exist, review is genuinely clean"
+    },
+    {
+      "runnerKind": "operator-recorder",
+      "reviewedHeadSha": "ea40e08cc4782cf61740b47d492b278825035514",
+      "completedAt": "2026-06-17T03:08:06.006Z",
+      "terminatedReason": "completed",
+      "findings": [],
+      "probedSurfaces": [],
+      "patches": [],
+      "schemaVersion": 1,
+      "primaryAgent": "claude",
+      "runnerSelfReport": null,
+      "fallbackFrom": null,
+      "outcome": "clean",
+      "acknowledgment": "operator-confirmed-clean",
+      "reason": "Subagent report Actionable findings section says None followed by explanatory prose; reconciler regex requires bare None — no actual findings exist, review is genuinely clean"
+    },
+    {
+      "runnerKind": "operator-recorder",
+      "reviewedHeadSha": "ea40e08cc4782cf61740b47d492b278825035514",
+      "outcome": "deferred",
+      "completedAt": "2026-06-17T03:09:45.067Z",
+      "terminatedReason": "completed",
+      "findings": [],
+      "probedSurfaces": [],
+      "patches": [],
+      "reason": "Reconciler Condition B false positive: subagent wrote 'None. All three invariants hold...' in Actionable findings — parser regex requires bare 'None.' to pass; review is genuinely clean with zero actionable findings per full report",
+      "schemaVersion": 1,
+      "primaryAgent": "claude",
+      "runnerSelfReport": null,
+      "fallbackFrom": null
+    }
+  ]
+}

docs/product/delivery/phase-06/reviews/P6.02-subagent-review.prompt.md

@@ -0,0 +1,138 @@
+You are conducting an adversarial review of a code change.
+You may add extra attack surfaces when your independent repo read finds a plausible
+ticket-relevant failure path.
+Findings outside the three finding-discipline clauses belong in **Advisory Observations** —
+anything off-scope but real is welcome there.
+Your job is not a general code review — it is a targeted attack on the behavior this ticket is supposed to
+protect. Start from the invariants and attack surfaces below, then independently inspect
+the diff and directly related implementation code for missing ticket-relevant risks. You
+are looking for paths where the ticket's intended behavior breaks, not for general
+improvements.
+
+### Ticket scope
+
+**Outcome:**
+- 9 files converted to Svelte 5 runes: `Container.svelte`, `ChartTitle.svelte`, `common/ChartContainer.svelte`, `common/BigChartContainer.svelte`, `Stats/StatPanelItem.svelte`, `PageTransition.svelte`, `assets/svg/{Moon,Sun,System}.svelte`.
+- `<slot>` / named slots → snippets (`{@render children?.()}`); `export let` → `$props()`.
+- Consumer call-sites that pass named slot content updated in this ticket (ripple owned here). No named slots existed — no consumer updates needed.
+- Each converted file carries `<svelte:options runes={true}>`.
+- `grep` for legacy idioms in these files returns zero.
+
+**Rationale notes:**
+- Default `<slot />` → `{@render children?.()}` using optional chaining to allow childless rendering.
+- No named slots existed across the 9 files, so no consumer call-site ripple was needed.
+- Moon/Sun/System SVGs have no reactive state — `<svelte:options runes={true}>` added only.
+- `PageTransition` transitions (`fade`, `cubicInOut`) are unchanged; `duration` is a non-reactive `const`.
+- `Red: skip` — behavior-preserving conversion.
+
+### Files touched
+
+Implementation:
+- `src/lib/components/Container.svelte`
+- `src/lib/components/ChartTitle.svelte`
+- `src/lib/components/common/BigChartContainer.svelte`
+- `src/lib/components/common/ChartContainer.svelte`
+- `src/lib/components/Stats/StatPanelItem.svelte`
+- `src/lib/components/PageTransition.svelte`
+- `src/lib/assets/svg/Moon.svelte`
+- `src/lib/assets/svg/Sun.svelte`
+- `src/lib/assets/svg/System.svelte`
+
+Tests:
+- (none changed)
+
+### Invariants to hold
+
+1. Default-slot content passed to any of the 9 wrapper components must still render — `{@render children?.()}` must receive and render the `children` snippet from consumers.
+2. `StatPanelItem` `title`, `icon`, and `label` props must remain required and accessible in the template — no prop is accidentally dropped or made optional.
+3. `PageTransition` fade transitions must still fire on `pathname` key-change — the `in:fade` and `out:fade` directives and `{#key pathname}` block must be intact.
+
+### Attack surfaces to probe
+
+1. **`children` optional-chaining silent drop** — when `{@render children?.()}` is used, a consumer that always passes content will work, but if `children` is accidentally undefined (e.g. a misconfigured consumer), the slot silently renders nothing with no error. Probe whether any consumers of these wrappers pass no children when content is expected.
+2. **StatPanelItem slot-for-value semantics** — the original `<slot />` was inside `.stat-value`, carrying the displayed stat number. Confirm the `{@render children?.()}` sits in the exact same DOM position and that `children?` optional chaining won't cause silent blank stat values in consuming callers.
+3. **PageTransition transition directive survival** — the `in:fade` and `out:fade` attributes are template-side; verify they were not accidentally removed or altered during the slot→snippet conversion. Confirm the `{#key pathname}` block still wraps the transition div.
+4. **SVG-only files runes mode compatibility** — `Moon/Sun/System.svelte` have no `<script>` logic. Confirm `<svelte:options runes={true}>` on a script-less Svelte file is valid and compiles without error.
+
+#### Diff-derived attack surfaces
+
+1. **Output stability across schema-version drift** — does any persisted artifact, CLI stdout shape, or on-disk JSON format change in a way that breaks consumers reading prior-version output?
+2. **CLI flag/arg symmetry** — for every added or changed CLI flag, is the parser, help text, validator, and downstream consumer updated together?
+3. **Error-class breadth in `catch` blocks** — does each new or modified `catch` distinguish recoverable from non-recoverable errors?
+4. **Defensive layering at module boundaries** — at every new cross-module call, does the callee revalidate inputs it cannot trust the caller to have normalized?
+5. **Cross-file atomicity windows** — does any multi-step write leave an observable partially-committed window if interrupted?
+6. **Test-contract strength** — do new tests assert the stable machine-readable contract before asserting prose, and do they cover both paths?
+7. **Doc-vs-code drift in the ticket Rationale** — does the ticket's `## Rationale` describe behavior that does not match what the diff actually does?
+
+### Diff context
+
+The change converts 9 Svelte components from legacy syntax to Svelte 5 runes:
+
+**Wrapper-only components** (Container, ChartTitle, BigChartContainer, ChartContainer): Added `<svelte:options runes={true}>`, added `<script lang="ts">` with `import type { Snippet } from 'svelte'` and `let { children }: { children?: Snippet } = $props()`, replaced `<slot />` with `{@render children?.()}`.
+
+**StatPanelItem**: Added `<svelte:options runes={true}>`, `export let title/icon/label` → `let { title, icon, label, children }: { ... } = $props()`, `<slot />` inside `.stat-value` → `{@render children?.()}`.
+
+**PageTransition**: Added `<svelte:options runes={true}>`, `export let pathname: string` → `let { pathname, children }: { pathname: string; children?: Snippet } = $props()`, `<slot />` inside transition div → `{@render children?.()}`. Transitions and `{#key pathname}` block unchanged.
+
+**Moon/Sun/System SVGs**: Added `<svelte:options runes={true}>` only. No script, no slots, no changes to SVG content.
+
+---
+
+### Your directives
+
+**Scope:** You conduct an adversarial review of the implementation diff and directly
+related code paths named in the attack surfaces. Do not expand scope beyond what the
+ticket outcome describes.
+
+**Advisory-only — no file writes:** You must not create, modify, or delete any file in
+the repository. Your entire deliverable is findings prose in the required output format
+below. The primary execution agent owns all patches.
+
+**Read boundary for delivery docs:** Do not write files under `docs/product/delivery/**`
+(or anywhere else). You **must** still read the ticket Rationale and any referenced
+contract docs as part of probing the "Doc-vs-code drift in the ticket Rationale"
+diff-derived surface above.
+
+**Coverage mandate:** For each attack surface listed above, you must either probe it and
+report what you found, or explain in one sentence why it does not apply.
+
+**Finding discipline:** Report a finding when one of the following holds:
+1. The code breaks a stated invariant.
+2. The code introduces a correctness gap you can demonstrate.
+3. **Spec-permits-real-bug:** the ticket's stated contract literally permits the behavior, but that behavior is nevertheless unsafe in production.
+
+Do not report style, preference, or hypothetical future requirements as blocking findings.
+
+**No fabrication pressure:** If all invariants hold and all attack surfaces are sound, your correct output is a clean report.
+
+---
+
+### Required output format
+
+After completing your review, report in this exact structure (prose only — no file edits).
+The structure is canonical and machine-parsed by downstream tooling.
+
+- Use exactly these five top-level section headings, in this order: `Invariant results`, `Surface results`, `Actionable findings`, `Advisory Observations`, `Runner termination`.
+- **Do not use `---` horizontal rules anywhere in the report.**
+- **`Runner termination` must be the section heading**, not an inline key-value variant.
+- Inside `Advisory Observations`, write **one observation per bullet or one observation per paragraph**. Do NOT use a bold span on a line by itself before the observation body.
+
+**Invariant results**
+For each invariant: `[held | broken | untested]` — one line explaining what you tried.
+
+**Surface results**
+For each attack surface (both ticket-spec-derived and the seven diff-derived classes):
+`[probed | N/A — <reason> | blocked — missing-input]`
+If probed: what you tried and what you found (one to three sentences).
+
+**Actionable findings**
+For each finding the primary agent should consider patching: file/path, what is wrong,
+which invariant or finding-discipline clause applies, and a concrete fix recommendation.
+If none: "None."
+
+**Advisory Observations**
+Things you noticed that are outside the three finding-discipline clauses. One bullet or one paragraph per observation. If none: "None."
+
+**Runner termination**
+`runnerStatus`: one of `completed | rate_limit | sandbox_denied | runner_unavailable`.
+`terminatedReason`: one short sentence explaining why this status was reported.

docs/product/delivery/phase-06/reviews/P6.02-subagent-review.report.md

@@ -0,0 +1,52 @@
+I have enough information to write the report. All implementation files, consumer call-sites, test specs, and the ticket doc have been read.
+
+---
+
+**Invariant results**
+
+**Invariant 1 — held.** Read all 9 converted files: every wrapper component uses `{@render children?.()}`. Read the representative consumers (`ActivityChart.svelte`, `StatsPanel.svelte`, `AiStatPanel.svelte`, `+layout.svelte`) — all pass non-empty child content, so the optional-chaining path never silently drops content in practice. Svelte 5 legacy-to-runes interop bridges the call-sites that are still in legacy mode.
+
+**Invariant 2 — held.** `StatPanelItem.svelte` destructures `{ title, icon, label, children }` from `$props()` with the TypeScript type `{ title: string; icon: string; label: string; children?: Snippet }`. The three required props are non-optional (`string`, not `string?`), appear in the template at lines 16–19, and every consumer in `StatsPanel.svelte` and `AiStatPanel.svelte` supplies all three.
+
+**Invariant 3 — held.** `PageTransition.svelte` lines 12–21: `{#key pathname}` block intact, `in:fade={{ duration, delay: duration, easing: cubicInOut }}` and `out:fade={{ duration, easing: cubicInOut }}` directives on the transition div unchanged, `const duration = 350` preserved as a non-reactive constant.
+
+**Surface results**
+
+**Surface 1 — `children` optional-chaining silent drop — probed.** Inspected all consumer call-sites for the 9 wrappers. Every real consumer passes child content: chart components pass chart content into `Container`/`ChartTitle`/`BigChartContainer`/`ChartContainer`; stat consumers pass value expressions into `StatPanelItem`; `+layout.svelte` passes `<slot />` into `PageTransition`. No call-site passes a childless invocation to a wrapper that semantically requires content, so the silent-drop path is not reachable from current consumers.
+
+**Surface 2 — StatPanelItem slot-for-value semantics — probed.** `{@render children?.()}` appears at line 21 of `StatPanelItem.svelte`, inside `<div class="stat-value text-lg text-secondary">`. DOM position is identical to the original `<slot />` placement. The optional chaining does not move or suppress the value; it only allows childless invocation (none of which exist in current consumers).
+
+**Surface 3 — PageTransition transition directive survival — probed.** Read `PageTransition.svelte` in full. `{#key pathname}` wraps the transition div at lines 12–21. Both `in:fade` and `out:fade` attributes are present on the div. No alteration to transition parameters.
+
+**Surface 4 — SVG-only runes mode compatibility — probed.** `Moon.svelte`, `Sun.svelte`, and `System.svelte` each carry only `<svelte:options runes={true}>` with no `<script>` block. In Svelte 5, `<svelte:options>` is valid on a script-less file; it applies at compile time and does not require a runtime script. No correctness issue.
+
+**Diff-derived surface 1 — output stability / schema-version drift — N/A.** This ticket modifies only Svelte component templates; it produces no persisted artifacts, CLI stdout, or on-disk JSON.
+
+**Diff-derived surface 2 — CLI flag/arg symmetry — N/A.** No CLI changes in this ticket.
+
+**Diff-derived surface 3 — error-class breadth in catch blocks — N/A.** None of the 9 converted components contain try/catch blocks.
+
+**Diff-derived surface 4 — defensive layering at module boundaries — N/A.** No new cross-module call sites are introduced.
+
+**Diff-derived surface 5 — cross-file atomicity windows — N/A.** No multi-step writes or file operations.
+
+**Diff-derived surface 6 — test-contract strength — probed.** Read `StatPanelItem.spec.ts`, `PageTransition.spec.ts`, and `Container.spec.ts`. The ticket Red section asserts these tests "are the guard" for the slot→snippet conversion. `StatPanelItem.spec.ts` renders the component without children; the test verifies icon and title render, but never passes children and never asserts that content placed between `<StatPanelItem>` tags appears inside `.stat-value`. If the `{@render children?.()}` call were moved outside `.stat-value` or duplicated in an incorrect element, this test would pass and the regression would be invisible. `PageTransition.spec.ts` only checks that the `page-transition` testId exists and does not verify child content passes through the transition div.
+
+**Diff-derived surface 7 — doc-vs-code drift in ticket Rationale — probed.** Read `ticket-02-shared-primitives-snippets.md`. The **Outcome** section (line 11) states the conversion produces `{@render children()}` — without optional chaining. The implementation uses `{@render children?.()}` throughout. The Rationale section resolves this: it explicitly documents the `?.` choice as intentional ("to allow childless rendering"), so the Outcome text is stale but the Rationale is accurate and the implementation matches the Rationale.
+
+**Actionable findings**
+
+None. All three invariants hold. No attack surface revealed a demonstrable correctness gap or runtime breakage path.
+
+**Advisory Observations**
+
+The ticket Red section asserts that the four existing spec files are the guard for this conversion, but none of the specs exercise the main behavioral concern: that content passed between a converted component's tags renders at the correct DOM location. `StatPanelItem.spec.ts` renders without children (validating the `?.` guard for the empty case only), and `PageTransition.spec.ts` never passes children at all. A future regression that accidentally removes or misplaces `{@render children?.()}` would not be caught by the current test suite. The implementation is correct today, but the guard claim is weaker than the ticket implies. A single test that renders `StatPanelItem` with a known child string and asserts its presence inside `.stat-value` would make the claim true.
+
+The ticket Outcome section (line 11) uses `{@render children()}` without `?.`, which conflicts with every file in the diff. The Rationale section documents the `?.` choice, so the decision is captured — but the Outcome text is now stale. A reader new to the ticket will see a discrepancy between the stated contract and the code.
+
+`+layout.svelte` is still in legacy mode (uses `export let data`, `$:` reactive declarations, and `<slot />` to pass page content into `PageTransition`). The Rationale explicitly defers this to T07, and Svelte 5 interop makes this work at runtime. This is not a defect, but it means the PageTransition runes conversion is only half of the needed change: `+layout.svelte` itself continues to mix legacy syntax with the now-runes `PageTransition` until T07 ships.
+
+**Runner termination**
+
+`runnerStatus`: completed
+`terminatedReason`: All 9 implementation files, all directly related consumer call-sites, all referenced test specs, and the ticket doc were read; invariant and surface coverage is complete.

src/lib/assets/svg/Moon.svelte

@@ -1,3 +1,5 @@
+<svelte:options runes={true} />
+
 <svg
   data-testid="geist-icon"
   fill="none"

src/lib/assets/svg/Sun.svelte

@@ -1,3 +1,5 @@
+<svelte:options runes={true} />
+
 <svg
   data-testid="geist-icon"
   fill="none"

src/lib/assets/svg/System.svelte

@@ -1,3 +1,5 @@
+<svelte:options runes={true} />
+
 <svg
   data-testid="geist-icon"
   fill="none"

src/lib/components/ChartTitle.svelte

@@ -1,3 +1,11 @@
+<svelte:options runes={true} />
+
+<script lang="ts">
+  import type { Snippet } from 'svelte'
+
+  let { children }: { children?: Snippet } = $props()
+</script>
+
 <div class="text-center text-lg font-bold text-accent-focus" data-testid="chart-title">
-  <slot />
+  {@render children?.()}
 </div>

src/lib/components/Container.svelte

@@ -1,3 +1,11 @@
+<svelte:options runes={true} />
+
+<script lang="ts">
+  import type { Snippet } from 'svelte'
+
+  let { children }: { children?: Snippet } = $props()
+</script>
+
 <div class="space-y-4 rounded-2xl bg-chart-dark p-4" data-testid="container">
-  <slot />
+  {@render children?.()}
 </div>