refactor(charts): standalone charts [P6.04]

docs/product/delivery/phase-06/reviews/P6.04-pr-review.triage.json

@@ -0,0 +1,10 @@
+{
+  "schemaVersion": 1,
+  "recordedAt": "2026-06-17T03:39:37.505Z",
+  "outcome": "skipped",
+  "note": "PR review disabled by policy",
+  "prBodyRefresh": {
+    "attemptedAt": "2026-06-17T03:39:40.760Z",
+    "status": "updated"
+  }
+}

docs/product/delivery/phase-06/reviews/P6.04-subagent-review.ledger.json

@@ -0,0 +1,37 @@
+{
+  "ticket": "P6.04",
+  "invocations": [
+    {
+      "runnerKind": "claude-cli",
+      "reviewedHeadSha": "dc35ac26f0932894469f3a05393460306f14e34e",
+      "outcome": "clean",
+      "completedAt": "2026-06-17T03:37:59.277Z",
+      "terminatedReason": "completed",
+      "rawOutput": "docs/product/delivery/phase-06/reviews/P6.04-subagent-review.report.md",
+      "filledPrompt": "docs/product/delivery/phase-06/reviews/P6.04-subagent-review.prompt.md",
+      "fallbackLevel": "preferred",
+      "schemaVersion": 1,
+      "primaryAgent": "claude",
+      "runnerSelfReport": "completed",
+      "fallbackFrom": null,
+      "findings": [],
+      "probedSurfaces": [],
+      "patches": []
+    },
+    {
+      "runnerKind": "operator-recorder",
+      "reviewedHeadSha": "dc35ac26f0932894469f3a05393460306f14e34e",
+      "outcome": "deferred",
+      "completedAt": "2026-06-17T03:38:42.472Z",
+      "terminatedReason": "completed",
+      "findings": [],
+      "probedSurfaces": [],
+      "patches": [],
+      "reason": "Condition B false positive: subagent used --- horizontal rules in report (violating template instructions), causing the section parser to misread the Actionable findings section. Actual findings: None. Advisory observations are non-blocking doc-vs-code drift notes (on:update T05 exception not in ticket Outcome) and DailyGauge selectedDate ordering note.",
+      "schemaVersion": 1,
+      "primaryAgent": "claude",
+      "runnerSelfReport": null,
+      "fallbackFrom": null
+    }
+  ]
+}

docs/product/delivery/phase-06/reviews/P6.04-subagent-review.prompt.md

@@ -0,0 +1,135 @@
+You are conducting an adversarial review of a code change.
+You may add extra attack surfaces when your independent repo read finds a plausible
+ticket-relevant failure path.
+Findings outside the three finding-discipline clauses belong in **Advisory Observations** —
+anything off-scope but real is welcome there.
+Your job is not a general code review — it is a targeted attack on the behavior this ticket is supposed to
+protect. Start from the invariants and attack surfaces below, then independently inspect
+the diff and directly related implementation code for missing ticket-relevant risks. You
+are looking for paths where the ticket's intended behavior breaks, not for general
+improvements.
+
+### Ticket scope
+
+**Outcome:**
+- These 8 files use runes only: `LineChart/LineChart.svelte`, `PieChart/PieChart.svelte`, `ScatterPlot/ScatterPlot.svelte`, `Treemap/Treemap.svelte`, `TimelineChart/TimelineChart.svelte`, `GaugeChart/DailyGauge.svelte`, `AiTokenBarChart/AiTokenBarChart.svelte`, `AiLinesPieChart/AiLinesPieChart.svelte`.
+- All apply the T01 ECharts recipe (`$derived option` + `$effect(setOption)`).
+- Each file carries `<svelte:options runes={true}>`.
+- `grep` for legacy idioms in these files returns zero (modulo T05-deferred `on:update` cross-boundary bridges in TimelineChart and DailyGauge).
+
+**Rationale:**
+- Red first: n/a (`Red: skip`).
+- Why this path: mechanical application of the proven T01 recipe across the remaining standalone charts.
+- Alternative considered: per-chart tickets — rejected as ceremony for a solo operator on mechanical work.
+- Deferred: chart control components (T05). `on:update` in TimelineChart and DailyGauge are T05-deferred cross-boundary bridges (same as ActivityChart in T03 — TypeScript rejects `onupdate` as unknown prop until T05 migrates the Svelte 4 child components).
+
+### Files touched
+
+Implementation:
+src/lib/components/LineChart/LineChart.svelte
+src/lib/components/PieChart/PieChart.svelte
+src/lib/components/ScatterPlot/ScatterPlot.svelte
+src/lib/components/Treemap/Treemap.svelte
+src/lib/components/TimelineChart/TimelineChart.svelte
+src/lib/components/GaugeChart/DailyGauge.svelte
+src/lib/components/AiTokenBarChart/AiTokenBarChart.svelte
+src/lib/components/AiLinesPieChart/AiLinesPieChart.svelte
+
+Tests:
+None (Red: skip — behavior-preserving refactor; existing spec guards unchanged).
+
+### Invariants to hold
+
+1. Every file in scope has `<svelte:options runes={true}>` and zero remaining legacy idioms (`export let`, `$:`, `afterUpdate`), with the explicitly documented exception of `on:update` in TimelineChart and DailyGauge deferred to T05.
+2. The T01 ECharts recipe is applied in each chart: `option` is `$derived`, `chart.setOption(option)` is called inside a `$effect`, and the `$effect` guards against an uninitialized chart ref.
+3. `DailyGauge`'s local `selectedDate` state is properly managed: initialized to `$state('')`, updated by the side-effecting `$effect` when `defaultDate` changes, and updated by `onUpdate` when the user selects a date.
+
+### Attack surfaces to probe
+
+1. `DailyGauge.svelte` — `$effect` for `selectedDate` update: `$effect(() => { if (defaultDate && (!selectedDate || !availableDates.includes(selectedDate))) { selectedDate = defaultDate } })`. Probe whether this `$effect` creates an infinite loop: `selectedDate` is `$state`, reading `selectedDate` inside the `$effect` marks it as a dependency, writing `selectedDate = defaultDate` triggers a re-run. Since `availableDates.includes(selectedDate)` then returns true, the condition is false on the second run and no write occurs — but verify this reasoning holds.
+2. `DailyGauge.svelte` — dual `$effect` for chart init: a `$effect` sets `selectedDate` (writing state), and a separate `$effect` re-renders the chart (reading `option` which reads `data` which reads `selectedDate`). Probe whether the ordering guarantee between these two effects is correct: does the chart re-render fire after `selectedDate` is settled, or can it fire with the stale empty string?
+3. `TimelineChart.svelte` — `durations` local state: `let durations = $state(durationsProp)` captures the initial prop. Same pattern as ActivityChart in T03. Probe whether `hasData` and `option` are derived from the local `durations` (not `durationsProp`), and that the `onUpdate` handler writes to `durations` (not `durationsProp`).
+4. `Treemap.svelte` — `$page` store in runes mode: `$page` is used inside two `$derived` expressions. In Svelte 5 runes mode, the `$store` auto-subscribe syntax is still valid. Probe whether TypeScript and the Svelte compiler accept `$page.params.projectName` inside `$derived(...)` in a runes-mode file, and whether the derived values re-run when the page params change.
+5. `AiLinesPieChart.svelte` — nullable option propagation: `option` is `$derived(hasData ? buildAiLinesPieOption(slices!) : null)`. The `$effect` guards with `if (option) chart.setOption(option)`. Probe whether the non-null assertion `slices!` is safe at the point it's evaluated (i.e., `hasData` is true, meaning `slices !== null`).
+
+#### Diff-derived attack surfaces
+
+1. **Output stability across schema-version drift** — [N/A — purely in-memory component refactor; no persisted artifacts or schemas changed].
+2. **CLI flag/arg symmetry** — [N/A — no CLI flags modified].
+3. **Error-class breadth in `catch` blocks** — [N/A — no try/catch blocks in these files; same as T03].
+4. **Defensive layering at module boundaries** — Probe whether `createTimelineChartOption`, `createDisciplineGaugeData`, and `createDisciplineGaugeOption` handle their inputs defensively. `DailyGauge` passes `selectedDate` (which starts as empty string `''`) to `createDisciplineGaugeData`; verify the helper handles an empty string date without throwing before the `$effect` sets it to `defaultDate`.
+5. **Cross-file atomicity windows** — [N/A — no multi-step file writes].
+6. **Test-contract strength** — Probe whether `PieChart.spec.ts`, `AiTokenBarChart.spec.ts`, and `AiLinesPieChart.spec.ts` are compatible with the runes migration — specifically, whether they pass props in a way that works with `$props()`.
+7. **Doc-vs-code drift in the ticket Rationale** — Read the ticket Rationale and outcome against the diff. Verify: (a) T01 recipe applied to all 8 charts; (b) `on:update` bridges in TimelineChart and DailyGauge are correctly identified as T05-deferred; (c) the `DailyGauge` reactive state pattern is correctly described.
+
+### Diff context
+
+Eight files migrated from Svelte 4 to Svelte 5 runes. Patterns:
+
+- **Simple charts (LineChart, PieChart, ScatterPlot, Treemap, AiTokenBarChart, AiLinesPieChart):** `export let` → `$props()`, `$:` → `$derived`, `afterUpdate` → `$effect`. Template unchanged.
+- **TimelineChart:** Same as ActivityChart in T03 — `durations` prop renamed to `durationsProp`, local `let durations = $state(durationsProp)` created, `on:update={onUpdate}` kept as T05 bridge.
+- **DailyGauge:** Most complex. `selectedDate` stays as `$state('')`. `availableDates` and `defaultDate` become `$derived`. The reactive side-effect `$: if (defaultDate && ...) { selectedDate = defaultDate }` becomes `$effect(() => { if (defaultDate && ...) { selectedDate = defaultDate } })`. `on:update={onUpdate}` kept as T05 bridge.
+- `Treemap` uses `$page` from `$app/stores` inside `$derived()` — valid in runes mode.
+
+---
+
+### Your directives
+
+**Scope:** You conduct an adversarial review of the implementation diff and directly
+related code paths named in the attack surfaces. Do not expand scope beyond what the
+ticket outcome describes.
+
+**Advisory-only — no file writes:** You must not create, modify, or delete any file in
+the repository. Your entire deliverable is findings prose in the required output format
+below. The primary execution agent owns all patches.
+
+**Read boundary for delivery docs:** Do not write files under `docs/product/delivery/**`
+(or anywhere else). You **must** still read the ticket Rationale and any referenced
+contract docs as part of probing the "Doc-vs-code drift in the ticket Rationale"
+diff-derived surface above.
+
+**Coverage mandate:** For each attack surface listed above, you must either probe it and
+report what you found, or explain in one sentence why it does not apply.
+
+**Finding discipline:** Report a finding when one of the following holds:
+
+1. The code breaks a stated invariant.
+2. The code introduces a correctness gap you can demonstrate.
+3. **Spec-permits-real-bug:** the ticket's stated contract literally permits the
+   behavior, but that behavior is nevertheless unsafe in production.
+
+Do not report style, preference, or hypothetical future requirements as blocking findings.
+
+**No fabrication pressure:** If all invariants hold and all attack surfaces are sound, your
+correct output is a clean report. Do not invent findings to justify the review step.
+
+---
+
+### Required output format
+
+After completing your review, report in this exact structure (prose only — no file edits).
+
+- Use exactly these five top-level section headings, in this order:
+  `Invariant results`, `Surface results`, `Actionable findings`,
+  `Advisory Observations`, `Runner termination`.
+- **Do not use `---` horizontal rules anywhere in the report.**
+- **`Runner termination` must be the section heading**, not an inline key-value variant.
+- Inside `Advisory Observations`, write **one observation per bullet or one observation per paragraph**. Do NOT use a bold span on a line by itself before the observation body.
+
+**Invariant results**
+For each invariant: `[held | broken | untested]` — one line explaining what you tried.
+
+**Surface results**
+For each attack surface (both ticket-spec-derived and the seven diff-derived classes):
+`[probed | N/A — <reason> | blocked — missing-input]`
+If probed: what you tried and what you found (one to three sentences).
+
+**Actionable findings**
+If none: "None."
+
+**Advisory Observations**
+If none: "None."
+
+**Runner termination**
+runnerStatus: completed | rate_limit | sandbox_denied | runner_unavailable
+terminatedReason: one short sentence explaining why this status was reported.