ENT-13880: Added error-checks for half-promises / attrs without promiser outside of macros#86
Open
SimonThalvorsen wants to merge 2 commits intocfengine:mainfrom
Open
ENT-13880: Added error-checks for half-promises / attrs without promiser outside of macros#86SimonThalvorsen wants to merge 2 commits intocfengine:mainfrom
SimonThalvorsen wants to merge 2 commits intocfengine:mainfrom
Conversation
Missing semicolons not handled, leave this to the formatter.
SimonThalvorsen
force-pushed
the
ENT-13880
branch
from
b5f6a1a to
9f32835
Compare
olehermanse
reviewed
Apr 23, 2026
olehermanse
reviewed
Apr 23, 2026
Comment on lines
+6
to
+11
| "string" | ||
| @if minimum_version(3.18) | ||
| string => $($(baz)); | ||
| @else | ||
| string => $($(baz)); | ||
| @endif |
Member
There was a problem hiding this comment.
Please try to expand these tests a bit more, for example;
Suggested change
| "string" | |
| @if minimum_version(3.18) | |
| string => $($(baz)); | |
| @else | |
| string => $($(baz)); | |
| @endif | |
| "string" | |
| @if minimum_version(3.18) | |
| string => $($(baz)); | |
| @else | |
| string => $($(baz)); | |
| @endif | |
| "string" | |
| # comment | |
| @if minimum_version(3.18) | |
| # comment | |
| # comment | |
| string => $($(baz)); | |
| # comment | |
| @else | |
| # comment | |
| string => $($(baz)); | |
| # comment | |
| @endif |
olehermanse
reviewed
Apr 24, 2026
| bundle agent main | ||
| { | ||
| vars: | ||
| "string" |
Member
There was a problem hiding this comment.
Please format with cfengine format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.