ENT-13879: Expanded syntax-description to include if param is optional#6079
Merged
olehermanse merged 2 commits intocfengine:masterfrom Apr 24, 2026
Merged
ENT-13879: Expanded syntax-description to include if param is optional#6079olehermanse merged 2 commits intocfengine:masterfrom
olehermanse merged 2 commits intocfengine:masterfrom
Conversation
Contributor
Author
SimonThalvorsen
force-pushed
the
ENT-13879
branch
4 times, most recently
from
1e71add to
6ad9bba
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
olehermanse
reviewed
Apr 22, 2026
olehermanse
reviewed
Apr 22, 2026
olehermanse
reviewed
Apr 22, 2026
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
6ad9bba to
cf92041
Compare
olehermanse
reviewed
Apr 22, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Looks good overall, just some smaller suggestions.
Member
|
@SimonThalvorsen When this one is done and merged, you should try to adjust cf-promises / cf-agent to also use these minimums and maximums. Right now, before this change, there is no way to know if a call has too many args without actually running it (IIRC). With this new info, cf-promises could detect more errors earlier. (Do this in a separate PR). |
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
cf92041 to
b0a55a9
Compare
larsewi
reviewed
Apr 23, 2026
olehermanse
requested changes
Apr 23, 2026
Member
olehermanse
left a comment
olehermanse
left a comment
There was a problem hiding this comment.
Please adjust FnArgcRange as discussed above - union can be removed or raw could be used and there could be an explaining comment.
…r func Ticket: ENT-13879 Changelog: title Signed-off-by: Simon Halvorsen <simon.halvorsen@northern.tech>
SimonThalvorsen
force-pushed
the
ENT-13879
branch
from
b0a55a9 to
ce1bd62
Compare
olehermanse
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: ENT-13879
Changelog: title