Skip to content

Compile the tag attribute regex once, not per tag [ai] #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghedwards merged 1 commit into from
Sep 11, 2026
Merged

Compile the tag attribute regex once, not per tag [ai] #74

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cfml.parsing/src/main/java/cfml/parsing/cfmentat/tag/CFMLStartTag.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ public AttributeItem(int linePos, int i, int inputPos, String attrName, String a
}

static protected final String REG_ATTRIBUTES = "(?si)(\\w+)[\\s=]+(((\\x22|\\x27|#)((?!\\4).|\\4{2})*\\4))";
// Compiled once: getAttributes() runs for every tag with attributes in a scan.
static private final Pattern ATTRIBUTES_PATTERN = Pattern.compile(REG_ATTRIBUTES, Pattern.CASE_INSENSITIVE);
private static CFMLStartTag INSTANCE = null;

protected CFMLStartTag(final String description, final String startDelimiter, final String closingDelimiter,
Expand Down Expand Up @@ -121,7 +123,7 @@ protected ArrayList getAttributes(String inData) {
Matcher matcher;
Pattern pattern;
String attributeName, attributeValue;
pattern = Pattern.compile(REG_ATTRIBUTES, Pattern.CASE_INSENSITIVE);
pattern = ATTRIBUTES_PATTERN;
matcher = pattern.matcher(inData);
if (inData.trim().endsWith("&")) {
userMessage(0, "stripAttributes", "Last attribute cannot be an ampersand", "ERR", null);
Expand Down
Loading