Skip to content

Increase size param now that data is larger #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpears merged 1 commit into from
Jun 12, 2026
Merged

Increase size param now that data is larger #244

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion complaint_search/serializer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class SearchInputSerializer(serializers.Serializer):
format = serializers.ChoiceField(FORMAT_CHOICES, default=PARAMS["format"])
field = serializers.ChoiceField(FIELD_CHOICES, default=PARAMS["field"])
size = serializers.IntegerField(
min_value=0, max_value=10000000, default=PARAMS["size"]
min_value=0, max_value=20000000, default=PARAMS["size"]
)
frm = serializers.IntegerField(
min_value=0, max_value=10000, default=PARAMS["frm"]
Expand Down
4 changes: 2 additions & 2 deletions complaint_search/tests/test_views_search.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,13 +214,13 @@ def test_search_with_size__invalid_smaller_than_min_number(
@mock.patch("complaint_search.es_interface.search")
def test_search_with_size__invalid_exceed_max_number(self, mock_essearch):
url = reverse("complaint_search:search")
params = {"size": 10000001}
params = {"size": 20000001}
mock_essearch.return_value = "OK"
response = self.client.get(url, params)
self.assertEqual(status.HTTP_400_BAD_REQUEST, response.status_code)
mock_essearch.assert_not_called()
self.assertDictEqual(
{"size": ["Ensure this value is less than or equal to 10000000."]},
{"size": ["Ensure this value is less than or equal to 20000000."]},
response.data,
)

Expand Down
Loading