feat: add desktop offline dictionary support - #27
Merged
Merged
Conversation
Decidetto
marked this pull request as ready for review
September 6, 2026 12:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the existing mobile dictionary feature to desktop. Select text and choose Define to look up English or Chinese words, with downloads and pack management in Settings > Dictionaries.
Share dictionary lookup, validation, recovery, and state management with mobile while retaining this fork's manifest hosting. Stream desktop downloads directly to disk in native code, reduce progress updates, and distinguish verification from downloading. Match existing settings styles and action icons, and reuse a shared progress bar for dictionaries, About, Sync, and chapter translation.
Validation on this branch: 94 desktop tests, 524 mobile tests, and 991 core tests passed, plus desktop/mobile typechecks. The same desktop implementation passed 4 native tests and was manually verified through local Windows preview builds. Measured English-pack transfer improved from 13.7 seconds to 1.6 seconds with an unchanged checksum. All existing dependency versions are preserved.
The desktop implementation is also included in upstream PR codedogQBY#767. Online fallback remains a separate follow-up.