Repository navigation
Add Viewer-controlled shared Windows themes (#118) - #138
Merged
Merged
Conversation
6 tasks done
chammoru
marked this pull request as ready for review
October 13, 2026 21:37
This was referenced Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #118. Windows MFC only; no Qt changes. The user has reviewed the applications and explicitly authorized merge and the subsequent 2.8.0 release after disclosure of the native 200% testing limitation.
Verification and limits
Local CoreRegressionTests and WindowsUiTypographyTests pass, including buffered/menu resource checks (warmed GDI 46/46). Full Viewer integration passes 830 checks and startup passes 39 at each native 125/150/175% scale. Previously completed actual System Light → Dark → Light and Night sky contrast on/off checks preserved loaded sources, zoom, frame and ROI/results; contrast scrollbar mouse/keyboard fallback was exercised. Active Windows and app settings were restored.
The shared native evidence also records the separately delivered #139 comparison work and its 690-check Comparator integration runs; that feature code is not in this PR. High-DPI comparison panel sizing is delivered with #139. This PR's focused shared changes plus #139 form the reviewed final build.
Native 200% remains unverified because this monitor's regular scale list ends at 175%; 192-DPI font/layout calculations are tested, not presented as a native 200% run. One PC and one contrast scheme do not establish every Windows version or popup state. These limits were disclosed before the user's delivery approval.
Evidence: theme verification, actual OS acceptance.
Local development version stays
0.0.0-dev; the later tagged Actions release supplies2.8.0. Existing untracked design work is excluded. Packaging/signing/GitHub Release/Store completion belongs to that asynchronous tagged workflow, not this PR's local checks.한국어
Viewer에만 테마 메뉴를 두고 Comparator가 공통 설정을 따릅니다. Timeline 스크롤바와 메뉴 깜빡임도 수정했습니다. 실제 Windows 테마·고대비 전환 및 125/150/175% 검증을 마쳤고 원래 설정으로 복원했습니다. 200%는 계산 검사만 통과했으며 실화면 검증은 하지 못했다는 한계를 안내한 뒤, 사용자가 별도 PR 병합과 2.8.0 릴리즈를 승인했습니다. #139 다중 비교 기능 코드는 이 PR에 넣지 않았습니다.