Repository navigation
refactor: share output row writing and tensor access checks - #211
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
输出转换器重复维护逐行写出逻辑，Tensor 的只读和可写访问器也各自维护一套相同检查。本次将 6 处输出循环收敛到 WriteOutputRows，将 2 处 Tensor 检查收敛到内部 CheckedTensorData，共减少 6 份重复实现，生产代码净减少 44 行。
输出转换器继续负责业务字段、来源校验和结果对齐；共享循环保留可选槽位的原始行号、失败诊断和写入计数，Runtime 仍负责输出原子发布。Tensor 两个入口分别调用 Data() 和 MutableData()，保留检查顺序、空值规则和诊断。
验证：