Repository navigation
@chargebee/entitlements and @chargebee/openfeature packages
#37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cb-srinaths
wants to merge
22
commits into
main
Choose a base branch
from
openfeature
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2be591b
add openfeature package
cb-srinaths f124d7a
refactor openfeature package
cb-srinaths d1550ec
fix: apply CodeRabbit auto-fixes
coderabbitai[bot] fd25a99
v0.1.0-alpha.1
cb-srinaths 206d329
upgrade to use pnpm v11
cb-srinaths 1011a98
check if web connection is closed before refreshing
cb-srinaths b43d86f
remove node 20 and add 26
cb-srinaths 3423989
bump engines in package.json [skip ci]
cb-srinaths 79a1b9b
major rewrite
cb-srinaths b475596
split into `@chargebee/entitlements` and `@chargebee/openfeature` pac…
cb-srinaths b63fc22
delete todo
cb-srinaths 6d9e731
add feature class
cb-srinaths e8e1839
refactor
cb-srinaths 2b728c8
agents.md
cb-srinaths 7395127
bump entitlements@0.1.0-alpha.2
cb-srinaths 126a553
bump versions
cb-srinaths d7601c7
add express and next examples for entitlements
cb-srinaths 27f764a
fix undefined fetch error
cb-srinaths f7026d0
add entitlements architecture and flow
cb-srinaths 5991355
add getFromAPI method
cb-srinaths 5942830
bump versions
cb-srinaths 5a28a55
add benchmark for entitlements package
cb-srinaths File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # Important information for agents | ||
|
|
||
| - When writing something intended for human consumption, (comment, commit message, reply to prompt) use as few words as possible. Pick every word meticulously to reduce the volume to a strict minimum. Be down to the point. Less is more. | ||
|
|
||
| - Avoid superlatives and praise. Stop telling me I am absolutely right. Give me the cold hard truth. | ||
|
|
||
| - Avoid magic numbers and strings by extracting recurring or meaningful values into descriptive constants (const) or enums. Keep self-explanatory, one-off values inline to avoid clutter. If a value comes from a spec (e.g. HTTP 200 OK), use a constant regardless. | ||
|
|
||
| - Reduce code indentation. Avoid Arrow Anti-Pattern. Leverage early return and continue. | ||
|
|
||
| - Keep function names short. Less than 30 characters. | ||
|
|
||
| - Use enums instead of booleans for function parameters. | ||
|
|
||
| - Let the reader of the code breathe. Add empty lines between logical blocks of code. | ||
|
|
||
| - Add a small, to the point, comment to explain *what* the block does and *why*. Use examples when possible. Propose ASCII drawings to explain complete systems. | ||
|
|
||
| - Treat member visibility changes as a breaking design shift. Keep all fields and functions private unless external access is strictly required by the design. Prompt the user for explicit approval before changing any access modifier from private to internal or public. | ||
|
|
||
| - Program to levels of abstraction. Lower-level mechanics (e.g., raw hardware I/O, sector parsing, direct socket streams) must be encapsulated in a dedicated driver/abstraction layer. Expose clean, high-level APIs to the rest of the application so calling code works with domain concepts, not raw implementation details. | ||
|
|
||
| - Don't touch blocks of code unrelated to the feature you implement. e.g. Don't add comments to a block of code if you did not create it or modify it. As much as possible try to minimize the number of changed lines when implementing a feature. | ||
|
|
||
| - Strictly adhere to the layered boundary hierarchy: each layer may only communicate with its immediate neighbor directly below it. Never "punch holes" through layers (e.g., controllers or UI components must never directly call database queries, raw hardware drivers, or low-level network clients; always route through the intermediate service/abstraction layer). | ||
|
|
||
| - Always use {}, even on a one-line "if" statement. | ||
|
|
||
| When you write a commit message, follow these 7 rules: | ||
| Rule 1: Separate the subject line from the body with a single blank line. | ||
| Rule 2: Limit the subject line to 50 characters (72 is the absolute hard limit). | ||
| Rule 3: Capitalize the first letter of the subject line. | ||
| Rule 4: Do not end the subject line with a period. | ||
| Rule 5: Use the imperative mood in the subject line (e.g., "Fix bug," "Add feature," | ||
| not "Fixed" or "Adds"). Test formula: It must complete the sentence: "If applied, | ||
| this commit will [your subject line here]". | ||
| Rule 6: Wrap the body text manually at 72 characters to prevent Git formatting issues. | ||
| Rule 7: Use the body to explain what and why vs. how. Assume the code explains the how; | ||
| the message must explain the context and reasoning. | ||
|
|
||
| - If the prompt indicates that a bug is being fixed, don't write the fix right away. First write the test. Observe it failing. Then write the fix. And observe the test passing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.