Bug fixes#1
Open
PureSpeeed wants to merge 2 commits into
Open
Conversation
was causing a bug that allowed for spells to be rapidly cast by non-host players
pheki
reviewed
Aug 14, 2024
| while packet_size > 0: | ||
| var packet: Dictionary = Steam.readP2PPacket(packet_size, channel) | ||
| open_packet(packet["steam_id_remote"], bytes2var(packet["data"])) | ||
| open_packet(packet["steamIDRemote"], bytes2var(packet["data"])) |
There was a problem hiding this comment.
This GodotSteam commit changed it to steam_id_remote: GodotSteam/GodotSteam@9497ecf
That commit is included on GodotSteam 3.10 and higher, so it looks like the version specified on the README is incorrect.
It's probably a better idea to try GodotSteam 3.10 or higher instead of that patch, and if it works, update the README: https://github.com/GodotSteam/GodotSteam/releases/tag/g333-s152-gs310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug that allowed non-host players to rapidly spam spells during the cast time of certain spells.
Fixed a bug that didn't allow multiplayer while in debug mode.