CHEF-27761: Add download URL validation with retry logic#426
Open
tpowell-progress wants to merge 2 commits into
Open
CHEF-27761: Add download URL validation with retry logic#426tpowell-progress wants to merge 2 commits into
tpowell-progress wants to merge 2 commits into
Conversation
tpowell-progress
force-pushed
the
chef-27761-url-validation
branch
from
4e4a722 to
08e2c0a
Compare
sean-sype-simmons
approved these changes
Jun 18, 2026
sean-sype-simmons
left a comment
sean-sype-simmons
left a comment
Contributor
There was a problem hiding this comment.
update branch and then this looks good.
…on race conditions This change addresses CHEF-27761 by adding validation of download URLs before returning artifact information. This prevents the race condition where mixlib-install returns metadata for packages that aren't yet available on the CDN. Features: - Added validate_download_url_with_retry() method with exponential backoff - Implements 3 retries with configurable wait times (default: 1s, 2s, 4s) - Uses HTTP HEAD requests for lightweight validation (no full download) - Configurable via MIXLIB_INSTALL_VALIDATE_URLS environment variable - Disabled by default for backward compatibility - Clear error messages indicating CDN propagation delays This ensures all mixlib-install consumers (test-kitchen, knife bootstrap, etc.) benefit from the validation without requiring code changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Thomas Powell <104777878+tpowell-progress@users.noreply.github.com>
Resolve RuboCop violations reported in CI: - remove redundant begin/rescue wrapper - avoid shadowed exception rescue list - use self-assignment shorthand for backoff multiplier No behavior change; this is lint-only cleanup for CHEF-27761 changes. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Thomas Powell <104777878+tpowell-progress@users.noreply.github.com>
tpowell-progress
force-pushed
the
chef-27761-url-validation
branch
from
5e42474 to
a6f8324
Compare
neha-p6
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses CHEF-27761 by adding download URL validation to prevent CDN propagation race conditions.
Problem: Chef client upgrades fail when mixlib-install returns package metadata before packages are available on the CDN. This leaves Windows systems in a broken state.
Solution:
Testing:
Fixes: CHEF-27761