Repair rubocop refusing to run (#97)

[sinfomicien]

Description

As i start to look into the problem, got multiples problem to handle. So i tried to correct them all:

• Upgrade dependencies
• Use ESlint instead of TSLint(obsolete)
• Remove a null token parameter in findFiles call, generating extension load error
• Replace rootPath (deprecated) by workspaceFolders[0].uri.fsPath
• Correct a language/snippet file loading problem(berkshelf vs berkfile) (Extension issue #142)
• added shell: true in spawn execution, it was failing without with node 20.
• Removed test from node 15 (unsupported)
• Adding test for node 18 and node 20.
• Change gif image URL in README (master branch is now main)
• Escape $ from some snippet description to avoid warning in VSCode

Now, all problems are correctly highlighted (even if for now, it’s not possible to correct them automatically).

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Chore (non-breaking change that does not add functionality or fix an issue)

Checklist:

• I have read the CONTRIBUTING document.
• I have run the pre-merge tests locally and they pass.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• If Gemfile.lock has changed, I have used --conservative to do it and included the full output in the Description above.
• All new and existing tests passed.
• All commits have been signed-off for the Developer Certificate of Origin.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
2 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[sinfomicien]

@clintoncwolfe , is it possible to review this PR ? Could it be merged at some point ?

[sinfomicien]

@nikhil2611 could you review the PR please ?

[nikhil2611]

Hey @sinfomicien , Please review the updated changes

[Copilot]

Pull request overview

This PR aims to get the VS Code Chef extension back into a healthy/runnable state by addressing several extension activation, linting, and language/snippet loading issues (including the Berksfile grammar wiring mentioned in #142), alongside dependency/CI maintenance updates.

Changes:

• Adds/rewires Berksfile language grammar support (new chef_berksfile syntax file + package.json grammar entry changes).
• Adjusts Rubocop/Cookstyle execution logic (workspace folder handling, spawn options) and fixes a findFiles call signature issue.
• Updates snippet content to avoid $-related snippet parsing warnings and refreshes a README asset URL.

Reviewed changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
syntaxes/chef_berksfile.cson.json	Introduces a Berksfile TextMate grammar shim (includes Ruby scope).
snippets/chef_inspec_resources.json	Escapes $ in snippet bodies and adjusts a couple of description strings.
README.md	Updates the install/demo GIF URL.
package.json	Updates activation/grammar contributions, including Berksfile grammar mapping.
extension.ts	Fixes findFiles token usage, updates workspace root handling, and adjusts Rubocop spawning.
.github/dependabot.yml	Removes dependency ignore rules.

Suppressed comments (1)

snippets/chef_inspec_resources.json:2711

• Snippet description strings are displayed as plain text; escaping $ here will show the backslash to users (e.g. \$ORACLE_HOME). Keep $ORACLE_HOME unescaped in the description and only escape $ where snippet parsing occurs (the body).

    "description": "Use the `oracledb_listener_conf` Chef InSpec audit resource to test the listeners settings of Oracle DB, typically located at `\\$ORACLE_HOME/network/admin/listener.ora` or `\\$ORACLE_HOME\\network\\admin\\listener.ora` depending upon the platform.",

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

Pull request overview

Copilot reviewed 5 out of 6 changed files in this pull request and generated no new comments.

Suppressed comments (2)

package.json:30

• With only workspaceContains:**/metadata.rb in activationEvents, the extension won’t activate for non-cookbook workspaces (for example, InSpec profiles) even though this extension contributes chef_inspec/chef_berksfile languages. That prevents linting/commands from running unless a metadata.rb exists. Consider re-adding onLanguage:* activation events for the Chef languages so the extension activates when those file types are opened.

  "activationEvents": [
    "workspaceContains:**/metadata.rb"
  ],

extension.ts:231

• shell: isWindows was added for the main rubocop run here, but checkCookstyleVersion() still spawns rubocopPath without shell. On Windows, rubocopPath is a .bat (see candidate paths), so the version check is likely to fail even though the main lint run now works. Please apply the same shell handling to the version check spawn as well.

		const isWindows = process.platform === 'win32';
		let spawn = require("child_process").spawnSync;
		let rubocop: any;
		if (rubocopConfigFile) {
			rubocop = spawn(rubocopPath, ["--parallel", "--config", rubocopConfigFile, "-f", "j"].concat(paths), { shell: isWindows, cwd: workspaceRoot });

[sinfomicien]

Everything seems ok to me !

[sanghinitin]

LGTM