fix(knowledge): harvest processed-store dedupe + flush-gate hardening (wiki-audit) - #41
Merged
Merged
Conversation
…; harden the flush PR gate
- harvest.js seeds its dedupe set from ~/.dev-loop/queue/.processed.jsonl too,
so a flushed insight is never re-queued when the next Stop re-parses the
unchanged transcript (read-only; corrupt lines skipped)
- pre-flush-pr-gate.sh now recognizes quoted --body-file paths and expands
leading ~, $HOME, ${HOME} — the skill's own example command was being denied
- knowledge-flush SKILL: gate-resolvable --body-file path guidance (cites
command-text-inspected-before-execution), and step 5 retires EVERY handled
candidate (incl. dropped) so auto-flush cannot loop hourly on unpromotable rows
- tests: harvest.bats (8) + pre-flush-pr-gate.bats (13), regressions observed
red on the unmodified code first
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Full LLM-perspective audit of the bundled wiki + knowledge pipeline: mechanical lint sweep (0 defects across 141 pages), 15-scenario routing probe (11/13 UNIQUE, 2 ambiguities), 16-concern category-taxonomy walk (gaps G1-G10), and the harvest/flush pipeline audit that produced the fixes in the previous commit. Includes the adopted harvest-dedupe plan. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
LLM-perspective audit of the bundled wiki + knowledge pipeline, with the three pipeline defects it uncovered fixed and regression-tested.
Fixes
~/.dev-loop/queue/.processed.jsonl— a flushed insight is never re-queued when the next Stop re-parses the unchanged transcript (read-only, corrupt-line safe).--body-filepaths and expands~/$HOME/${HOME}— the flush skill's own example command was being denied with "no --body-file found".--body-filepath guidance (citescommand-text-inspected-before-execution); step 5 now retires every handled candidate (incl. dropped) so auto-flush cannot re-trigger hourly on unpromotable rows.Tests
tests/harvest.bats(8) andtests/pre-flush-pr-gate.bats(13); both regressions observed red on unmodified code first. Full suite: 315 tests, exit 0. Independent test-quality-auditor verdict: PASS.Audit deliverables (plans/wiki-audit/)
Refs #36 #37 #38 #39
🤖 Generated with Claude Code