fix(server): distinguish alive-but-busy from dead opencode process in health checks#248
Open
chriswritescode-dev wants to merge 1 commit into
Open
fix(server): distinguish alive-but-busy from dead opencode process in health checks#248chriswritescode-dev wants to merge 1 commit into
chriswritescode-dev wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce the concept of "alive but not ready" for the OpenCode server process. If the process is alive but not answering health probes (e.g., still starting, busy), treat it as degraded rather than killing and restarting it. Add unexpected exit detection so the supervisor can recover immediately on crashes.
isProcessAlive()to check process existence viaprocess.kill(pid, 0)onUnexpectedExit()listener system for crash detectionreadyfield toOpenCodeLifecycleStatus(separate fromhealthy)markBusy()setshealthy=true, ready=falseto prevent restart loopsopencode: "busy"in health endpoint when alive but not readyHEALTH_PROBE_TIMEOUT_MS(default 10s) for health check probesFiles
backend/src/routes/health.tsbackend/src/services/opencode-single-server.tsbackend/src/services/opencode-supervisor.tsbackend/test/routes/health.test.tsbackend/test/services/opencode-single-server.test.tsbackend/test/services/opencode-supervisor.test.tsshared/src/config/defaults.tsshared/src/config/env.ts