Repository navigation
fix(eql): build the TextEq query fixture's input as a frame, so v4_types compiles on next - #1261
Conversation
…pes compiles on next #1257 added a TextEq query to the v4 query fixture with an FfiValue input, and #1259 removed FfiValue from v4_types.rs. Each passed on its own; merged together on next, the test file does not compile. The input is now frame("alice@example.com"), as every other query there is, and the fixture's bytes are unchanged.
|
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Summary
nextdoesn't compile the EQL encryption tests'v4_types.rs, somise run test:encryptionfails there. Two PRs collided:TextEqquery to the v4 query fixture, building its input asFfiValue::String("alice@example.com".into());FfiValuefrom that file and built every input as a frame of a Rust value.Each passed CI on its own; merged together, the file names a type it no longer imports.
Changes
packages/eql/tests/encryption/tests/v4_types.rs: theTextEqquery's input is nowframe("alice@example.com"), the same as every other query in the file.Verification
From
packages/eql:cargo test -p eql-encryption-tests --test v4_types: 13 passed, 3 ignored (Postgres only).the_v4_query_fixture_is_what_the_dispatch_derivespasses against the committedv4_queries.json. That fixture compares bytes, so the new input frames identically to the old one.--test targets(16) and--test heap_hygiene(2) pass, andcargo fmt --checkis clean.Related
Fixes the combination of #1257 and #1259.