Skip to content

fix(eql): build the TextEq query fixture's input as a frame, so v4_types compiles on next - #1261

Merged
coderdan merged 1 commit into
nextfrom
fix/next-v4-types-texteq-frame
Oct 18, 2026
Merged

coderdan merged 1 commit into
nextfrom
fix/next-v4-types-texteq-frame

Conversation

@coderdan

Copy link
Copy Markdown
Contributor

Summary

next doesn't compile the EQL encryption tests' v4_types.rs, so mise run test:encryption fails there. Two PRs collided:

Each passed CI on its own; merged together, the file names a type it no longer imports.

Changes

  • packages/eql/tests/encryption/tests/v4_types.rs: the TextEq query's input is now frame("alice@example.com"), the same as every other query in the file.

Verification

From packages/eql:

  • cargo test -p eql-encryption-tests --test v4_types: 13 passed, 3 ignored (Postgres only).
  • the_v4_query_fixture_is_what_the_dispatch_derives passes against the committed v4_queries.json. That fixture compares bytes, so the new input frames identically to the old one.
  • --test targets (16) and --test heap_hygiene (2) pass, and cargo fmt --check is clean.

Related

Fixes the combination of #1257 and #1259.

…pes compiles on next

#1257 added a TextEq query to the v4 query fixture with an FfiValue input,
and #1259 removed FfiValue from v4_types.rs. Each passed on its own; merged
together on next, the test file does not compile. The input is now
frame("alice@example.com"), as every other query there is, and the
fixture's bytes are unchanged.
@coderdan
coderdan requested a review from a team as a code owner October 18, 2026 08:27
@changeset-bot

changeset-bot Bot commented Oct 18, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: cd6d7c5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: eeb887d0-93ed-4cbf-b90d-3bdea3dcfb31

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-18T08:29:15.810682Z cd6d7c5 PR opened
🔒 Security Review ✅ Completed 2026-10-18T08:29:41.507206Z cd6d7c5 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderdan
coderdan merged commit c612ed4 into next Oct 18, 2026
33 checks passed
@coderdan
coderdan deleted the fix/next-v4-types-texteq-frame branch October 18, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant