Repository navigation
chore(deps): bump lizard to 1.24.1 with its own hashes - #1322
Conversation
Dependabot's bump in #1152 moved the lizard pin to 1.24.1 but kept the 1.23.0 hashes, so `pip install --require-hashes` refused it and the advisory impact job failed. Regenerated with the command in the file header, which now names 1.24.1 too. ImpactGate 0.4.1 allows 1.24.1 (it excludes only 1.24.0), and lizard's dependencies did not change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015gYnhFvb3q6ykc5ExKZewS
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
cipherstash-agent
left a comment
There was a problem hiding this comment.
Attestation of review — Claude Code /code-review medium, with findings cross-checked via company-skills:cross-check-review-findings, against head bceca8a.
No critical or blocking issues. No findings.
- The
lizard==1.24.1wheel (746060a3…) and sdist (c022cf1a…) hashes match PyPI's published SHA-256 digests. impact-gate==0.4.1requireslizard!=1.24.0,>=1.17, so 1.24.1 is allowed.- The header pin list and regenerate command are consistent with the pinned entry. No other pin moved.
- No existing review feedback to cross-check (only bot status comments).
- No changeset is needed for a CI-tooling-only change.
Generated by Claude Code
Requested by Toby · project thread
Summary
The advisory "Change impact" CI job installs its analysis tools (ImpactGate and lizard, a code complexity tool) from a pinned file in which every package has a fixed SHA-256 hash. Dependabot's bump in #1152 changed the lizard version to 1.24.1 but kept the 1.23.0 hashes, so pip refused to install it and the job failed. This PR makes the same bump with lizard 1.24.1's real hashes. The blocker freshtonic raised about 1.24.0 no longer applies: ImpactGate 0.4.1 excludes only 1.24.0, and 1.24.1 is allowed.
Changes
.github/impact-gate/requirements.txt:lizard==1.24.1with its wheel and sdist hashes, regenerated with theuv pip compilecommand in the file header. That header (the pin list and the regenerate command) now names 1.24.1. No other pin moved.Verification
uv pip compile(the header's command, now with 1.24.1) changed only the lizard lines. The hashes match PyPI's746060a3…(wheel) andc022cf1a…(sdist).pip install --require-hashes --no-deps -r .github/impact-gate/requirements.txtsucceeded,pip checkreported no broken requirements, and it installed impact-gate 0.4.1 and lizard 1.24.1.python -m unittest discover -s scripts/tests -p test_impact_gate.py: all 22 tests passed against lizard 1.24.1. This is the same step the job runs after the install.Related
Supersedes #1152. Dependabot should close it once this merges, because lizard will already be at 1.24.1. Refs freshtonic's review on #1152.
Review notes
No changeset, because this only changes CI tooling. Two follow-ups from that review are deliberately left out of this PR. First, the
.github/dependabot.ymlcomment that says Dependabot regenerates the hashes, which #1152 shows is not true. Second, the missingsupply-chainlabel.Generated by Claude Code
Summary by CodeRabbit