Skip to content

fix(genesis): Denylist schema lacks zero-address and uniqueness validation #439

Description

@Lesnak1

Description

In Denylist.sol, the runtime contract enforces that:

  1. The owner cannot be the zero address (initialize reverts).
  2. Denylisters cannot contain the zero address (addDenylister reverts).
  3. Denylisters should be unique to prevent redundant storage slots and duplicate key collisions during genesis allocation.

Currently, scripts/genesis/Denylist.ts does not validate these invariants, which allows malformed genesis configurations to pass validation and fail later during runtime contract execution.

Proposed Solution

  • Add validation in scripts/genesis/Denylist.ts to reject zero addresses for both owner and denylisters.
  • Add case-insensitive uniqueness validation for denylisters.
  • Add unit tests covering all edge cases.

I have the fix and test suite ready locally. Could you please assign this issue to me so I can submit a PR? Thanks!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions